From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"tom.leiming@gmail.com" <tom.leiming@gmail.com>,
"axboe@fb.com" <axboe@fb.com>
Cc: "hare@suse.de" <hare@suse.de>, "jthumshirn@suse.de" <jthumshirn@suse.de>
Subject: Re: [PATCH v3 2/4] block: add a read barrier in blk_queue_enter()
Date: Mon, 27 Mar 2017 15:44:00 +0000 [thread overview]
Message-ID: <1490629427.2461.8.camel@sandisk.com> (raw)
In-Reply-To: <20170327120658.29864-3-tom.leiming@gmail.com>
On Mon, 2017-03-27 at 20:06 +0800, Ming Lei wrote:
> diff --git a/block/blk-core.c b/block/blk-core.c
> index ad388d5e309a..5e8963bc98d9 100644
> --- a/block/blk-core.c
> +++ b/block/blk-core.c
> @@ -669,6 +669,15 @@ int blk_queue_enter(struct request_queue *q, bool no=
wait)
> if (nowait)
> return -EBUSY;
> =20
> + /*
> + * read pair of barrier in blk_mq_freeze_queue_start(),
> + * we need to order reading __PERCPU_REF_DEAD flag of
> + * .q_usage_counter and reading .mq_freeze_depth,
> + * otherwise the following wait may never return if the
> + * two reads are reordered.
> + */
> + smp_rmb();
> +
> ret =3D wait_event_interruptible(q->mq_freeze_wq,
> !atomic_read(&q->mq_freeze_depth) ||
> blk_queue_dying(q));
Since patch 4/4 modifies the comment introduced by this patch, I would have
preferred that patches 2/4 and 4/4 would have been combined into a single
patch. Anyway:
Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>
next prev parent reply other threads:[~2017-03-27 15:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 12:06 [PATCH v3 0/4] block: misc changes Ming Lei
2017-03-27 12:06 ` [PATCH v3 1/4] blk-mq: comment on races related with timeout handler Ming Lei
2017-03-27 12:11 ` Johannes Thumshirn
2017-03-27 12:06 ` [PATCH v3 2/4] block: add a read barrier in blk_queue_enter() Ming Lei
2017-03-27 12:14 ` Johannes Thumshirn
2017-03-27 15:44 ` Bart Van Assche [this message]
2017-03-27 12:06 ` [PATCH v3 3/4] block: rename blk_mq_freeze_queue_start() Ming Lei
2017-03-27 12:15 ` Johannes Thumshirn
2017-03-27 12:06 ` [PATCH v3 4/4] block: block new I/O just after queue is set as dying Ming Lei
2017-03-27 12:16 ` Johannes Thumshirn
2017-03-27 15:49 ` Bart Van Assche
2017-03-29 2:11 ` [PATCH v3 0/4] block: misc changes Ming Lei
2017-03-29 14:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1490629427.2461.8.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=axboe@fb.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linux-block@vger.kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).