From: Johannes Thumshirn <jthumshirn@suse.de>
To: Ming Lei <tom.leiming@gmail.com>
Cc: Jens Axboe <axboe@fb.com>,
linux-block@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>,
Bart Van Assche <bart.vanassche@sandisk.com>,
Hannes Reinecke <hare@suse.de>, Tejun Heo <tj@kernel.org>
Subject: Re: [PATCH v3 4/4] block: block new I/O just after queue is set as dying
Date: Mon, 27 Mar 2017 14:16:16 +0200 [thread overview]
Message-ID: <20170327121616.GD7237@linux-x5ow.site> (raw)
In-Reply-To: <20170327120658.29864-5-tom.leiming@gmail.com>
On Mon, Mar 27, 2017 at 08:06:58PM +0800, Ming Lei wrote:
> Before commit 780db2071a(blk-mq: decouble blk-mq freezing
> from generic bypassing), the dying flag is checked before
> entering queue, and Tejun converts the checking into .mq_freeze_depth,
> and assumes the counter is increased just after dying flag
> is set. Unfortunately we doesn't do that in blk_set_queue_dying().
>
> This patch calls blk_freeze_queue_start() in blk_set_queue_dying(),
> so that we can block new I/O coming once the queue is set as dying.
>
> Given blk_set_queue_dying() is always called in remove path
> of block device, and queue will be cleaned up later, we don't
> need to worry about undoing the counter.
>
> Cc: Bart Van Assche <bart.vanassche@sandisk.com>
> Cc: Tejun Heo <tj@kernel.org>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
> Signed-off-by: Ming Lei <tom.leiming@gmail.com>
> ---
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
Johannes Thumshirn Storage
jthumshirn@suse.de +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 N�rnberg
GF: Felix Imend�rffer, Jane Smithard, Graham Norton
HRB 21284 (AG N�rnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850
next prev parent reply other threads:[~2017-03-27 12:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-27 12:06 [PATCH v3 0/4] block: misc changes Ming Lei
2017-03-27 12:06 ` [PATCH v3 1/4] blk-mq: comment on races related with timeout handler Ming Lei
2017-03-27 12:11 ` Johannes Thumshirn
2017-03-27 12:06 ` [PATCH v3 2/4] block: add a read barrier in blk_queue_enter() Ming Lei
2017-03-27 12:14 ` Johannes Thumshirn
2017-03-27 15:44 ` Bart Van Assche
2017-03-27 12:06 ` [PATCH v3 3/4] block: rename blk_mq_freeze_queue_start() Ming Lei
2017-03-27 12:15 ` Johannes Thumshirn
2017-03-27 12:06 ` [PATCH v3 4/4] block: block new I/O just after queue is set as dying Ming Lei
2017-03-27 12:16 ` Johannes Thumshirn [this message]
2017-03-27 15:49 ` Bart Van Assche
2017-03-29 2:11 ` [PATCH v3 0/4] block: misc changes Ming Lei
2017-03-29 14:00 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170327121616.GD7237@linux-x5ow.site \
--to=jthumshirn@suse.de \
--cc=axboe@fb.com \
--cc=bart.vanassche@sandisk.com \
--cc=hare@suse.de \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).