From: tang.junhui@zte.com.cn
To: colyli@suse.de, mlyle@lyle.org
Cc: linux-bcache@vger.kernel.org, linux-block@vger.kernel.org,
tang.junhui@zte.com.cn
Subject: Re: Re: Re: [PATCH] bcache: stop writeback thread after detaching
Date: Wed, 22 Nov 2017 13:48:27 +0800 [thread overview]
Message-ID: <1511329707-22492-1-git-send-email-tang.junhui@zte.com.cn> (raw)
From: Tang Junhui <tang.junhui@zte.com.cn>
Hello Coly, Mike
> > If the change can be inside bch_register_lock, it would (just) be more
> > comfortable. The code is correct, because attach/detach sysfs is created
> > after writeback_thread created and writeback_rate_update worker
> > initialized, even these resources are initialized within
> > bch_register_lock and released out of bch)register_lock in your patch,
> > there won't be any race. It's OK to me.
>
> I think I agree with Coly that I'd prefer it to be moved down into the
> register lock, as I think that will be safer with any future changes.
> Are you willing to adjust it this way?
OK, I'll fix it and resend a v2 patch later.
Thanks,
Tang
next reply other threads:[~2017-11-22 5:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-22 5:48 tang.junhui [this message]
2017-11-22 7:28 Re: Re: [PATCH] bcache: stop writeback thread after detaching tang.junhui
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1511329707-22492-1-git-send-email-tang.junhui@zte.com.cn \
--to=tang.junhui@zte.com.cn \
--cc=colyli@suse.de \
--cc=linux-bcache@vger.kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=mlyle@lyle.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).