Re: Re: Re: [PATCH] bcache: stop writeback thread after detaching

Re: Re: Re: [PATCH] bcache: stop writeback thread after detaching

[tang.junhui]

From: Tang Junhui <tang.junhui@zte.com.cn>

Hello Coly, Mike

> > If the change can be inside bch_register_lock, it would (just) be more
> > comfortable. The code is correct, because attach/detach sysfs is created
> > after writeback_thread created and writeback_rate_update worker
> > initialized, even these resources are initialized within
> > bch_register_lock and released out of bch)register_lock in your patch,
> > there won't be any race. It's OK to me.
>
> I think I agree with Coly that I'd prefer it to be moved down into the
> register lock, as I think that will be safer with any future changes.
> Are you willing to adjust it this way?


OK, I'll fix it and resend a v2 patch later.    

Thanks,
Tang

Re: Re: Re: [PATCH] bcache: stop writeback thread after detaching

[tang.junhui]

From: Tang Junhui <tang.junhui@zte.com.cn>

Hi, Mike

Thanks for your reminder. I'll checkpatch carefully next time.

Thanks,
Tang