* [PATCH v2] Fix zone-append error code
[not found] <CGME20200705193332epcas5p409173a9d12f203d3817305dd3250ca59@epcas5p4.samsung.com>
@ 2020-07-05 19:29 ` Kanchan Joshi
[not found] ` <CGME20200705193337epcas5p4b15eec1bbd6dd687f706f9b8fd93c14a@epcas5p4.samsung.com>
2020-07-21 15:03 ` [PATCH v2] Fix zone-append error code Kanchan Joshi
0 siblings, 2 replies; 3+ messages in thread
From: Kanchan Joshi @ 2020-07-05 19:29 UTC (permalink / raw)
To: axboe; +Cc: linux-block, linux-kernel, Damien.LeMoal, Kanchan Joshi
Changes since v1:
- updated commit description
- added reviewed-by
Kanchan Joshi (1):
block: fix error code for zone-append
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v2] block: fix error code for zone-append
[not found] ` <CGME20200705193337epcas5p4b15eec1bbd6dd687f706f9b8fd93c14a@epcas5p4.samsung.com>
@ 2020-07-05 19:29 ` Kanchan Joshi
0 siblings, 0 replies; 3+ messages in thread
From: Kanchan Joshi @ 2020-07-05 19:29 UTC (permalink / raw)
To: axboe
Cc: linux-block, linux-kernel, Damien.LeMoal, Kanchan Joshi,
Selvakumar S, Nitesh Shetty, Javier Gonzalez
Avoid returning success when max_append_sectors is zero. This prevents
infinite loop in bio_iov_iter_get_pages().
Signed-off-by: Kanchan Joshi <joshi.k@samsung.com>
Signed-off-by: Selvakumar S <selvakuma.s1@samsung.com>
Signed-off-by: Nitesh Shetty <nj.shetty@samsung.com>
Signed-off-by: Javier Gonzalez <javier.gonz@samsung.com>
Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>
---
block/bio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/bio.c b/block/bio.c
index a7366c0..0cecdbc 100644
--- a/block/bio.c
+++ b/block/bio.c
@@ -1044,7 +1044,7 @@ static int __bio_iov_append_get_pages(struct bio *bio, struct iov_iter *iter)
size_t offset;
if (WARN_ON_ONCE(!max_append_sectors))
- return 0;
+ return -EINVAL;
/*
* Move page array up in the allocated memory for the bio vecs as far as
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] Fix zone-append error code
2020-07-05 19:29 ` [PATCH v2] Fix zone-append error code Kanchan Joshi
[not found] ` <CGME20200705193337epcas5p4b15eec1bbd6dd687f706f9b8fd93c14a@epcas5p4.samsung.com>
@ 2020-07-21 15:03 ` Kanchan Joshi
1 sibling, 0 replies; 3+ messages in thread
From: Kanchan Joshi @ 2020-07-21 15:03 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-block, linux-kernel, Damien.LeMoal, Kanchan Joshi
Hi Jens,
Is this fine to be picked?
On Mon, Jul 6, 2020 at 1:06 AM Kanchan Joshi <joshi.k@samsung.com> wrote:
>
> Changes since v1:
> - updated commit description
> - added reviewed-by
>
> Kanchan Joshi (1):
> block: fix error code for zone-append
>
> block/bio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --
> 2.7.4
>
--
Kanchan Joshi
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-07-21 15:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20200705193332epcas5p409173a9d12f203d3817305dd3250ca59@epcas5p4.samsung.com>
2020-07-05 19:29 ` [PATCH v2] Fix zone-append error code Kanchan Joshi
[not found] ` <CGME20200705193337epcas5p4b15eec1bbd6dd687f706f9b8fd93c14a@epcas5p4.samsung.com>
2020-07-05 19:29 ` [PATCH v2] block: fix error code for zone-append Kanchan Joshi
2020-07-21 15:03 ` [PATCH v2] Fix zone-append error code Kanchan Joshi
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).