* [PATCH v2] block: delete unused Kconfig
@ 2020-07-20 8:33 Jiufei Xue
2020-07-20 15:49 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Jiufei Xue @ 2020-07-20 8:33 UTC (permalink / raw)
To: axboe, tj; +Cc: linux-block, Jiufei Xue
Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
---
block/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/block/Kconfig b/block/Kconfig
index 9357d73..d52c9bc 100644
--- a/block/Kconfig
+++ b/block/Kconfig
@@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
config BLK_CGROUP_IOCOST
bool "Enable support for cost model based cgroup IO controller"
depends on BLK_CGROUP=y
- select BLK_RQ_IO_DATA_LEN
select BLK_RQ_ALLOC_TIME
help
Enabling this option enables the .weight interface for cost
--
1.8.3.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2] block: delete unused Kconfig
2020-07-20 8:33 [PATCH v2] block: delete unused Kconfig Jiufei Xue
@ 2020-07-20 15:49 ` Jens Axboe
2020-07-21 1:50 ` Jiufei Xue
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2020-07-20 15:49 UTC (permalink / raw)
To: Jiufei Xue, tj; +Cc: linux-block
On 7/20/20 2:33 AM, Jiufei Xue wrote:
> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
> ---
> block/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/block/Kconfig b/block/Kconfig
> index 9357d73..d52c9bc 100644
> --- a/block/Kconfig
> +++ b/block/Kconfig
> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
> config BLK_CGROUP_IOCOST
> bool "Enable support for cost model based cgroup IO controller"
> depends on BLK_CGROUP=y
> - select BLK_RQ_IO_DATA_LEN
> select BLK_RQ_ALLOC_TIME
> help
> Enabling this option enables the .weight interface for cost
What's the difference between v1 and v2? A commit message would
also be nice...
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] block: delete unused Kconfig
2020-07-20 15:49 ` Jens Axboe
@ 2020-07-21 1:50 ` Jiufei Xue
2020-07-21 1:51 ` Jens Axboe
0 siblings, 1 reply; 5+ messages in thread
From: Jiufei Xue @ 2020-07-21 1:50 UTC (permalink / raw)
To: Jens Axboe, tj; +Cc: linux-block
On 2020/7/20 下午11:49, Jens Axboe wrote:
> On 7/20/20 2:33 AM, Jiufei Xue wrote:
>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
>> ---
>> block/Kconfig | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/block/Kconfig b/block/Kconfig
>> index 9357d73..d52c9bc 100644
>> --- a/block/Kconfig
>> +++ b/block/Kconfig
>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
>> config BLK_CGROUP_IOCOST
>> bool "Enable support for cost model based cgroup IO controller"
>> depends on BLK_CGROUP=y
>> - select BLK_RQ_IO_DATA_LEN
>> select BLK_RQ_ALLOC_TIME
>> help
>> Enabling this option enables the .weight interface for cost
>
> What's the difference between v1 and v2? A commit message would
> also be nice...
> Sorry for the confusion. I have misspelled *unused* in patch v1.
Thanks,
Jiufei
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] block: delete unused Kconfig
2020-07-21 1:50 ` Jiufei Xue
@ 2020-07-21 1:51 ` Jens Axboe
2020-07-21 1:53 ` Jiufei Xue
0 siblings, 1 reply; 5+ messages in thread
From: Jens Axboe @ 2020-07-21 1:51 UTC (permalink / raw)
To: Jiufei Xue, tj; +Cc: linux-block
On 7/20/20 7:50 PM, Jiufei Xue wrote:
>
>
> On 2020/7/20 下午11:49, Jens Axboe wrote:
>> On 7/20/20 2:33 AM, Jiufei Xue wrote:
>>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
>>> ---
>>> block/Kconfig | 1 -
>>> 1 file changed, 1 deletion(-)
>>>
>>> diff --git a/block/Kconfig b/block/Kconfig
>>> index 9357d73..d52c9bc 100644
>>> --- a/block/Kconfig
>>> +++ b/block/Kconfig
>>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
>>> config BLK_CGROUP_IOCOST
>>> bool "Enable support for cost model based cgroup IO controller"
>>> depends on BLK_CGROUP=y
>>> - select BLK_RQ_IO_DATA_LEN
>>> select BLK_RQ_ALLOC_TIME
>>> help
>>> Enabling this option enables the .weight interface for cost
>>
>> What's the difference between v1 and v2? A commit message would
>> also be nice...
>> Sorry for the confusion. I have misspelled *unused* in patch v1.
Ah I see. Can you send a v3 that has a simple commit message at least?
--
Jens Axboe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] block: delete unused Kconfig
2020-07-21 1:51 ` Jens Axboe
@ 2020-07-21 1:53 ` Jiufei Xue
0 siblings, 0 replies; 5+ messages in thread
From: Jiufei Xue @ 2020-07-21 1:53 UTC (permalink / raw)
To: Jens Axboe, tj; +Cc: linux-block
On 2020/7/21 上午9:51, Jens Axboe wrote:
> On 7/20/20 7:50 PM, Jiufei Xue wrote:
>>
>>
>> On 2020/7/20 下午11:49, Jens Axboe wrote:
>>> On 7/20/20 2:33 AM, Jiufei Xue wrote:
>>>> Signed-off-by: Jiufei Xue <jiufei.xue@linux.alibaba.com>
>>>> ---
>>>> block/Kconfig | 1 -
>>>> 1 file changed, 1 deletion(-)
>>>>
>>>> diff --git a/block/Kconfig b/block/Kconfig
>>>> index 9357d73..d52c9bc 100644
>>>> --- a/block/Kconfig
>>>> +++ b/block/Kconfig
>>>> @@ -146,7 +146,6 @@ config BLK_CGROUP_IOLATENCY
>>>> config BLK_CGROUP_IOCOST
>>>> bool "Enable support for cost model based cgroup IO controller"
>>>> depends on BLK_CGROUP=y
>>>> - select BLK_RQ_IO_DATA_LEN
>>>> select BLK_RQ_ALLOC_TIME
>>>> help
>>>> Enabling this option enables the .weight interface for cost
>>>
>>> What's the difference between v1 and v2? A commit message would
>>> also be nice...
>>> Sorry for the confusion. I have misspelled *unused* in patch v1.
>
> Ah I see. Can you send a v3 that has a simple commit message at least?
>
Of course. I will send v3 soon.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-07-21 1:53 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-20 8:33 [PATCH v2] block: delete unused Kconfig Jiufei Xue
2020-07-20 15:49 ` Jens Axboe
2020-07-21 1:50 ` Jiufei Xue
2020-07-21 1:51 ` Jens Axboe
2020-07-21 1:53 ` Jiufei Xue
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).