From: "hch@lst.de" <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: "hch@lst.de" <hch@lst.de>,
Bart Van Assche <Bart.VanAssche@sandisk.com>,
"agk@redhat.com" <agk@redhat.com>,
"lars.ellenberg@linbit.com" <lars.ellenberg@linbit.com>,
"snitzer@redhat.com" <snitzer@redhat.com>,
"philipp.reisner@linbit.com" <philipp.reisner@linbit.com>,
"axboe@kernel.dk" <axboe@kernel.dk>,
"shli@kernel.org" <shli@kernel.org>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"dm-devel@redhat.com" <dm-devel@redhat.com>,
"drbd-dev@lists.linbit.com" <drbd-dev@lists.linbit.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"linux-raid@vger.kernel.org" <linux-raid@vger.kernel.org>
Subject: Re: [PATCH 12/23] sd: handle REQ_UNMAP
Date: Fri, 31 Mar 2017 09:18:44 +0200 [thread overview]
Message-ID: <20170331071844.GB3308@lst.de> (raw)
In-Reply-To: <yq17f36yypg.fsf@oracle.com>
On Thu, Mar 30, 2017 at 10:19:55PM -0400, Martin K. Petersen wrote:
> > If you manually change the provisioning mode to WS10 on a device that
> > must use WRITE SAME (16) to be able to address all blocks you're already
> > screwed right now, and with this patch you can screw yourself through
> > the WRITE_ZEROES path in addition to the DISCARD path.
>
> Oh, I see. We only had the LBA sanity check in place for write same, not
> for discard.
And btw, I'd be happy to add such a check, I'd just rather keep it out
of this patch. It might be a good idea if you give it a turn after
this series given that you have all the devices that have weird
provisioning modes while I don't..
next prev parent reply other threads:[~2017-03-31 7:18 UTC|newest]
Thread overview: 70+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-23 14:33 RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload Christoph Hellwig
2017-03-23 14:33 ` [PATCH 01/23] block: renumber REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-28 16:12 ` Bart Van Assche
2017-03-30 8:53 ` hch
2017-03-23 14:33 ` [PATCH 02/23] block: implement splitting of REQ_OP_WRITE_ZEROES bios Christoph Hellwig
2017-03-23 14:33 ` [PATCH 03/23] sd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-28 18:50 ` Bart Van Assche
2017-03-28 19:33 ` Mike Snitzer
2017-03-29 14:51 ` Paolo Bonzini
2017-03-29 16:28 ` Bart Van Assche
2017-03-29 16:53 ` Paolo Bonzini
2017-03-30 2:25 ` Martin K. Petersen
2017-03-23 14:33 ` [PATCH 04/23] md: support REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-23 14:33 ` [PATCH 05/23] dm: " Christoph Hellwig
2017-03-23 14:33 ` [PATCH 06/23] dm-kcopyd: switch to use REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-23 14:55 ` Mike Snitzer
2017-03-23 14:56 ` Christoph Hellwig
2017-03-23 15:10 ` Mike Snitzer
2017-03-27 9:12 ` Christoph Hellwig
2017-03-23 14:33 ` [PATCH 07/23] block: stop using blkdev_issue_write_same for zeroing Christoph Hellwig
2017-03-23 14:33 ` [PATCH 08/23] block: add a flags argument to (__)blkdev_issue_zeroout Christoph Hellwig
2017-03-23 14:33 ` [PATCH 09/23] block: add a REQ_UNMAP flag for REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-23 14:33 ` [PATCH 10/23] block: add a new BLKDEV_ZERO_NOFALLBACK flag Christoph Hellwig
2017-03-23 14:33 ` [PATCH 11/23] block_dev: use blkdev_issue_zerout for hole punches Christoph Hellwig
2017-03-28 16:50 ` Bart Van Assche
2017-03-30 8:59 ` hch
2017-03-23 14:33 ` [PATCH 12/23] sd: handle REQ_UNMAP Christoph Hellwig
2017-03-28 16:48 ` Bart Van Assche
2017-03-29 14:57 ` Paolo Bonzini
2017-03-30 9:02 ` hch
2017-03-30 15:28 ` Martin K. Petersen
2017-03-30 17:30 ` hch
2017-03-31 2:19 ` Martin K. Petersen
2017-03-31 7:18 ` hch [this message]
2017-03-23 14:33 ` [PATCH 13/23] nvme: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-23 14:33 ` [PATCH 14/23] zram: " Christoph Hellwig
2017-03-23 14:33 ` [PATCH 15/23] loop: " Christoph Hellwig
2017-03-23 14:33 ` [PATCH 16/23] brd: remove discard support Christoph Hellwig
2017-03-23 14:33 ` [PATCH 17/23] rbd: remove the discard_zeroes_data flag Christoph Hellwig
2017-03-23 14:33 ` [PATCH 18/23] rsxx: " Christoph Hellwig
2017-03-23 14:33 ` [PATCH 19/23] mmc: " Christoph Hellwig
2017-03-23 14:33 ` [PATCH 20/23] block: stop using discards for zeroing Christoph Hellwig
2017-03-23 14:33 ` [PATCH 21/23] drbd: make intelligent use of blkdev_issue_zeroout Christoph Hellwig
2017-03-23 14:33 ` [PATCH 22/23] drbd: implement REQ_OP_WRITE_ZEROES Christoph Hellwig
2017-03-30 10:06 ` Lars Ellenberg
2017-03-30 11:44 ` Christoph Hellwig
2017-03-30 12:50 ` [Drbd-dev] " Lars Ellenberg
2017-03-30 13:49 ` Mike Snitzer
2017-03-30 15:20 ` Martin K. Petersen
2017-03-30 23:15 ` Mike Snitzer
2017-03-31 2:34 ` Martin K. Petersen
2017-03-31 7:17 ` Christoph Hellwig
2017-03-23 14:33 ` [PATCH 23/23] block: remove the discard_zeroes_data flag Christoph Hellwig
2017-03-28 17:00 ` Bart Van Assche
2017-03-29 14:52 ` Paolo Bonzini
2017-03-30 9:06 ` hch
2017-03-30 15:29 ` Martin K. Petersen
2017-03-30 17:29 ` hch
2017-03-23 15:54 ` RFC: always use REQ_OP_WRITE_ZEROES for zeroing offload Lars Ellenberg
2017-03-23 17:02 ` Mike Snitzer
2017-03-23 22:53 ` Lars Ellenberg
2017-03-29 14:57 ` Paolo Bonzini
2017-03-27 9:10 ` Christoph Hellwig
2017-03-27 14:03 ` Mike Snitzer
2017-03-27 14:57 ` Christoph Hellwig
2017-03-27 15:08 ` [Drbd-dev] " Bart Van Assche
2017-03-30 9:04 ` Christoph Hellwig
2017-03-30 15:12 ` Mike Snitzer
2017-03-30 15:22 ` Martin K. Petersen
2017-03-30 15:38 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170331071844.GB3308@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@sandisk.com \
--cc=agk@redhat.com \
--cc=axboe@kernel.dk \
--cc=dm-devel@redhat.com \
--cc=drbd-dev@lists.linbit.com \
--cc=lars.ellenberg@linbit.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=philipp.reisner@linbit.com \
--cc=shli@kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).