From: "Theodore Y. Ts'o" <tytso@mit.edu>
To: Omar Sandoval <osandov@osandov.com>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH BLKTESTS V2 1/3] nvme/002: fix output format
Date: Thu, 21 Feb 2019 10:04:18 -0500 [thread overview]
Message-ID: <20190221150418.GB4062@mit.edu> (raw)
In-Reply-To: <20190220193500.GE8325@vader>
On Wed, Feb 20, 2019 at 11:35:00AM -0800, Omar Sandoval wrote:
> > It should fail on older cli versions, we want latest cli/tools to be
> > used when running these testcases so that all the latest tools are
> > also been tested for the compliance, else we might be running tests
> > with any bugs with older version(s) which are fixed already.
> >
> > Actually I'd like to add quick nvme-cli version check at the start of
> > each test that will certainly help/force user to have a latest version.
>
> Perfect, I was going to suggest adding a check for the minimum version
> needed for each test.
It would be great if we could document what is (a) the minimum version
for things to work at all, and (b) the ideal version to use so that
tests aren't being skipped due to version constraints and so we are
testing the kernel as much as possible.
Ideally, tests should either be designed primarily to test userspace,
or to test the kernel, so that people who want to use blktests aren't
having to build the latest versions of userspace.
(As an aside, Bart has told me that the failures I'm seeing with
srp/002 and srp/011 are due to the fact that I'm using a version of
multipathd which is too old. Apparently both the version of
multipathd in Debian stable *and* Debian unstable are still too old,
since they are still failing. Next stop, building multipathd from
the git repo.... Grrr......)
- Ted
next prev parent reply other threads:[~2019-02-21 15:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 20:23 [PATCH BLKTESTS V2 0/3] nvme: fix output formats Chaitanya Kulkarni
2019-02-19 20:23 ` [PATCH BLKTESTS V2 2/3] nvme/016: fix output format Chaitanya Kulkarni
2019-02-19 20:23 ` [PATCH BLKTESTS V2 3/3] nvme/017: " Chaitanya Kulkarni
[not found] ` <1550607835-11755-2-git-send-email-chaitanya.kulkarni@wdc.com>
2019-02-20 18:03 ` [PATCH BLKTESTS V2 1/3] nvme/002: " Omar Sandoval
2019-02-20 18:28 ` Chaitanya Kulkarni
2019-02-20 19:35 ` Omar Sandoval
2019-02-21 15:04 ` Theodore Y. Ts'o [this message]
2019-02-22 0:00 ` Chaitanya Kulkarni
2019-02-27 19:00 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190221150418.GB4062@mit.edu \
--to=tytso@mit.edu \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).