From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Omar Sandoval <osandov@osandov.com>
Cc: "linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH BLKTESTS V2 1/3] nvme/002: fix output format
Date: Wed, 20 Feb 2019 18:28:50 +0000 [thread overview]
Message-ID: <SN6PR04MB4527D0FAE8B353AEA45E0CD8867D0@SN6PR04MB4527.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20190220180327.GA8325@vader
On 02/20/2019 10:04 AM, Omar Sandoval wrote:
> On Tue, Feb 19, 2019 at 12:23:53PM -0800, Chaitanya Kulkarni wrote:
>> Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
>> ---
>> tests/nvme/002.out | 4996 ++++++++++++++++++++++++++--------------------------
>> 1 file changed, 2498 insertions(+), 2498 deletions(-)
>>
>> diff --git a/tests/nvme/002.out b/tests/nvme/002.out
>> index aa71d8f..abecda5 100644
>> --- a/tests/nvme/002.out
>> +++ b/tests/nvme/002.out
>> @@ -1,11 +1,11 @@
>> Running nvme/002
>>
>> -Discovery Log Number of Records 1000, Generation counter 1000
>> +Discovery Log Number of Records 1000, Generation counter 2000
>> =====Discovery Log Entry 0======
>> trtype: loop
>> adrfam: pci
>> subtype: nvme subsystem
>> -treq: not specified
>> +treq: not specified, sq flow control disable supported
>> portid: X
>> trsvcid:
>> subnqn: blktests-subsystem-0
>
> [snip]
>
> Why did this output change? An nvme-cli change, or a kernel change, or
> something else? And will this now fail with older versions of nvme-cli
> or the kernel instead?
>
This change is specific to nvme-cli only.
It should fail on older cli versions, we want latest cli/tools to be
used when running these testcases so that all the latest tools are
also been tested for the compliance, else we might be running tests
with any bugs with older version(s) which are fixed already.
Actually I'd like to add quick nvme-cli version check at the start of
each test that will certainly help/force user to have a latest version.
next prev parent reply other threads:[~2019-02-20 18:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-19 20:23 [PATCH BLKTESTS V2 0/3] nvme: fix output formats Chaitanya Kulkarni
2019-02-19 20:23 ` [PATCH BLKTESTS V2 2/3] nvme/016: fix output format Chaitanya Kulkarni
2019-02-19 20:23 ` [PATCH BLKTESTS V2 3/3] nvme/017: " Chaitanya Kulkarni
[not found] ` <1550607835-11755-2-git-send-email-chaitanya.kulkarni@wdc.com>
2019-02-20 18:03 ` [PATCH BLKTESTS V2 1/3] nvme/002: " Omar Sandoval
2019-02-20 18:28 ` Chaitanya Kulkarni [this message]
2019-02-20 19:35 ` Omar Sandoval
2019-02-21 15:04 ` Theodore Y. Ts'o
2019-02-22 0:00 ` Chaitanya Kulkarni
2019-02-27 19:00 ` Omar Sandoval
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=SN6PR04MB4527D0FAE8B353AEA45E0CD8867D0@SN6PR04MB4527.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=linux-block@vger.kernel.org \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).