* [PATCH] rsxx: add missed destroy_workqueue calls in remove
@ 2019-11-13 6:38 Chuhong Yuan
2019-11-14 21:00 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Chuhong Yuan @ 2019-11-13 6:38 UTC (permalink / raw)
Cc: Joshua Morris, Philip Kelleher, Jens Axboe, linux-block,
linux-kernel, Chuhong Yuan
The driver misses calling destroy_workqueue in remove like what is done
when probe fails.
Add the missed calls to fix it.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/block/rsxx/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/block/rsxx/core.c b/drivers/block/rsxx/core.c
index 76b73ddf8fd7..10f6368117d8 100644
--- a/drivers/block/rsxx/core.c
+++ b/drivers/block/rsxx/core.c
@@ -1000,8 +1000,10 @@ static void rsxx_pci_remove(struct pci_dev *dev)
cancel_work_sync(&card->event_work);
+ destroy_workqueue(card->event_wq);
rsxx_destroy_dev(card);
rsxx_dma_destroy(card);
+ destroy_workqueue(card->creg_ctrl.creg_wq);
spin_lock_irqsave(&card->irq_lock, flags);
rsxx_disable_ier_and_isr(card, CR_INTR_ALL);
--
2.23.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] rsxx: add missed destroy_workqueue calls in remove
2019-11-13 6:38 [PATCH] rsxx: add missed destroy_workqueue calls in remove Chuhong Yuan
@ 2019-11-14 21:00 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2019-11-14 21:00 UTC (permalink / raw)
To: Chuhong Yuan; +Cc: Joshua Morris, Philip Kelleher, linux-block, linux-kernel
On 11/12/19 11:38 PM, Chuhong Yuan wrote:
> The driver misses calling destroy_workqueue in remove like what is done
> when probe fails.
> Add the missed calls to fix it.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-11-14 21:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 6:38 [PATCH] rsxx: add missed destroy_workqueue calls in remove Chuhong Yuan
2019-11-14 21:00 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).