* [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
@ 2020-02-28 14:13 Dan Carpenter
2020-02-28 14:25 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-02-28 14:13 UTC (permalink / raw)
To: Jens Axboe, Dan Schatzberg; +Cc: linux-block, kernel-janitors
The alloc_workqueue() function returns NULL on error, it never returns
error pointers.
Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index da8ec0b9d909..a31ca5e04fae 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -897,7 +897,7 @@ static int loop_prepare_queue(struct loop_device *lo)
WQ_UNBOUND | WQ_FREEZABLE |
WQ_MEM_RECLAIM,
lo->lo_number);
- if (IS_ERR(lo->workqueue))
+ if (!lo->workqueue)
return -ENOMEM;
return 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
2020-02-28 14:13 [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue() Dan Carpenter
@ 2020-02-28 14:25 ` Jens Axboe
2020-02-28 16:11 ` Dan Carpenter
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Jens Axboe @ 2020-02-28 14:25 UTC (permalink / raw)
To: Dan Carpenter, Dan Schatzberg; +Cc: linux-block, kernel-janitors
On 2/28/20 7:13 AM, Dan Carpenter wrote:
> The alloc_workqueue() function returns NULL on error, it never returns
> error pointers.
>
> Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
I can't seem to find this commit?
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
2020-02-28 14:25 ` Jens Axboe
@ 2020-02-28 16:11 ` Dan Carpenter
2020-02-28 16:15 ` Dan Schatzberg
2020-02-28 17:21 ` [PATCH resend] " Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-02-28 16:11 UTC (permalink / raw)
To: Jens Axboe; +Cc: Dan Schatzberg, linux-block, kernel-janitors
On Fri, Feb 28, 2020 at 07:25:58AM -0700, Jens Axboe wrote:
> On 2/28/20 7:13 AM, Dan Carpenter wrote:
> > The alloc_workqueue() function returns NULL on error, it never returns
> > error pointers.
> >
> > Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
>
> I can't seem to find this commit?
I guess this went through Andrew Morton's tree. I'll resend to him.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
2020-02-28 14:25 ` Jens Axboe
2020-02-28 16:11 ` Dan Carpenter
@ 2020-02-28 16:15 ` Dan Schatzberg
2020-02-28 17:21 ` [PATCH resend] " Dan Carpenter
2 siblings, 0 replies; 6+ messages in thread
From: Dan Schatzberg @ 2020-02-28 16:15 UTC (permalink / raw)
To: Jens Axboe; +Cc: Dan Carpenter, linux-block, kernel-janitors
es65;5603;1cOn Fri, Feb 28, 2020 at 07:25:58AM -0700, Jens Axboe wrote:
> On 2/28/20 7:13 AM, Dan Carpenter wrote:
> > The alloc_workqueue() function returns NULL on error, it never returns
> > error pointers.
> >
> > Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
>
> I can't seem to find this commit?
>
> --
> Jens Axboe
>
This went through Andrew's tree as patch series "Charge loop device
i/o to issuing cgroup", v3., it is currently in linux-next.
Thanks for fixing this Dan.
Acked-by: Dan Schatzberg <schatzberg.dan@gmail.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH resend] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
2020-02-28 14:25 ` Jens Axboe
2020-02-28 16:11 ` Dan Carpenter
2020-02-28 16:15 ` Dan Schatzberg
@ 2020-02-28 17:21 ` Dan Carpenter
2020-03-01 1:02 ` Stephen Rothwell
2 siblings, 1 reply; 6+ messages in thread
From: Dan Carpenter @ 2020-02-28 17:21 UTC (permalink / raw)
To: Jens Axboe, Dan Schatzberg, Andrew Morton
Cc: linux-block, kernel-janitors, Stephen Rothwell, linux-mm
The alloc_workqueue() function returns NULL on error, it never returns
error pointers.
Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Dan Schatzberg <schatzberg.dan@gmail.com>
---
Resending because this goes through your -mm tree, Andrew. The
get_maintainer.pl script lead me astray.
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index da8ec0b9d909..a31ca5e04fae 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -897,7 +897,7 @@ static int loop_prepare_queue(struct loop_device *lo)
WQ_UNBOUND | WQ_FREEZABLE |
WQ_MEM_RECLAIM,
lo->lo_number);
- if (IS_ERR(lo->workqueue))
+ if (!lo->workqueue)
return -ENOMEM;
return 0;
--
2.11.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH resend] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue()
2020-02-28 17:21 ` [PATCH resend] " Dan Carpenter
@ 2020-03-01 1:02 ` Stephen Rothwell
0 siblings, 0 replies; 6+ messages in thread
From: Stephen Rothwell @ 2020-03-01 1:02 UTC (permalink / raw)
To: Dan Carpenter
Cc: Jens Axboe, Dan Schatzberg, Andrew Morton, linux-block,
kernel-janitors, linux-mm
[-- Attachment #1: Type: text/plain, Size: 1152 bytes --]
Hi all,
On Fri, 28 Feb 2020 20:21:36 +0300 Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> The alloc_workqueue() function returns NULL on error, it never returns
> error pointers.
>
> Fixes: 29dab2122492 ("loop: use worker per cgroup instead of kworker")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Dan Schatzberg <schatzberg.dan@gmail.com>
> ---
> Resending because this goes through your -mm tree, Andrew. The
> get_maintainer.pl script lead me astray.
>
> drivers/block/loop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/loop.c b/drivers/block/loop.c
> index da8ec0b9d909..a31ca5e04fae 100644
> --- a/drivers/block/loop.c
> +++ b/drivers/block/loop.c
> @@ -897,7 +897,7 @@ static int loop_prepare_queue(struct loop_device *lo)
> WQ_UNBOUND | WQ_FREEZABLE |
> WQ_MEM_RECLAIM,
> lo->lo_number);
> - if (IS_ERR(lo->workqueue))
> + if (!lo->workqueue)
> return -ENOMEM;
>
> return 0;
Added to linux-next from tomorrow (in case Andrew has better things to
do with his weekend :-)).
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-01 1:02 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-28 14:13 [PATCH] loop: Fix IS_ERR() vs NULL bugs in loop_prepare_queue() Dan Carpenter
2020-02-28 14:25 ` Jens Axboe
2020-02-28 16:11 ` Dan Carpenter
2020-02-28 16:15 ` Dan Schatzberg
2020-02-28 17:21 ` [PATCH resend] " Dan Carpenter
2020-03-01 1:02 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).