* [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list
@ 2020-03-23 17:50 Andy Shevchenko
2020-04-15 14:47 ` Andy Shevchenko
0 siblings, 1 reply; 5+ messages in thread
From: Andy Shevchenko @ 2020-03-23 17:50 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, linux-block, Jens Axboe
Cc: Andy Shevchenko
Instead of keeping NULL terminated array switch to use ARRAY_SIZE()
which helps to further clean up.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
drivers/block/zram/zcomp.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
index 1a8564a79d8d..e78e7a2ccfd5 100644
--- a/drivers/block/zram/zcomp.c
+++ b/drivers/block/zram/zcomp.c
@@ -29,7 +29,6 @@ static const char * const backends[] = {
#if IS_ENABLED(CONFIG_CRYPTO_ZSTD)
"zstd",
#endif
- NULL
};
static void zcomp_strm_free(struct zcomp_strm *zstrm)
@@ -67,7 +66,7 @@ bool zcomp_available_algorithm(const char *comp)
{
int i;
- i = __sysfs_match_string(backends, -1, comp);
+ i = sysfs_match_string(backends, comp);
if (i >= 0)
return true;
@@ -86,9 +85,9 @@ ssize_t zcomp_available_show(const char *comp, char *buf)
{
bool known_algorithm = false;
ssize_t sz = 0;
- int i = 0;
+ int i;
- for (; backends[i]; i++) {
+ for (i = 0; i < ARRAY_SIZE(backends); i++) {
if (!strcmp(comp, backends[i])) {
known_algorithm = true;
sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list
2020-03-23 17:50 [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list Andy Shevchenko
@ 2020-04-15 14:47 ` Andy Shevchenko
2020-05-06 12:43 ` Andy Shevchenko
2020-05-08 5:30 ` Minchan Kim
0 siblings, 2 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-04-15 14:47 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, linux-block, Jens Axboe
On Mon, Mar 23, 2020 at 07:50:08PM +0200, Andy Shevchenko wrote:
> Instead of keeping NULL terminated array switch to use ARRAY_SIZE()
> which helps to further clean up.
Any comments on this?
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> drivers/block/zram/zcomp.c | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
> index 1a8564a79d8d..e78e7a2ccfd5 100644
> --- a/drivers/block/zram/zcomp.c
> +++ b/drivers/block/zram/zcomp.c
> @@ -29,7 +29,6 @@ static const char * const backends[] = {
> #if IS_ENABLED(CONFIG_CRYPTO_ZSTD)
> "zstd",
> #endif
> - NULL
> };
>
> static void zcomp_strm_free(struct zcomp_strm *zstrm)
> @@ -67,7 +66,7 @@ bool zcomp_available_algorithm(const char *comp)
> {
> int i;
>
> - i = __sysfs_match_string(backends, -1, comp);
> + i = sysfs_match_string(backends, comp);
> if (i >= 0)
> return true;
>
> @@ -86,9 +85,9 @@ ssize_t zcomp_available_show(const char *comp, char *buf)
> {
> bool known_algorithm = false;
> ssize_t sz = 0;
> - int i = 0;
> + int i;
>
> - for (; backends[i]; i++) {
> + for (i = 0; i < ARRAY_SIZE(backends); i++) {
> if (!strcmp(comp, backends[i])) {
> known_algorithm = true;
> sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2,
> --
> 2.25.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list
2020-04-15 14:47 ` Andy Shevchenko
@ 2020-05-06 12:43 ` Andy Shevchenko
2020-05-08 5:30 ` Minchan Kim
1 sibling, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-06 12:43 UTC (permalink / raw)
To: Minchan Kim, Nitin Gupta, Sergey Senozhatsky, linux-block, Jens Axboe
On Wed, Apr 15, 2020 at 05:47:47PM +0300, Andy Shevchenko wrote:
> On Mon, Mar 23, 2020 at 07:50:08PM +0200, Andy Shevchenko wrote:
> > Instead of keeping NULL terminated array switch to use ARRAY_SIZE()
> > which helps to further clean up.
>
> Any comments on this?
Should I do anything about this?
>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/block/zram/zcomp.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
> > index 1a8564a79d8d..e78e7a2ccfd5 100644
> > --- a/drivers/block/zram/zcomp.c
> > +++ b/drivers/block/zram/zcomp.c
> > @@ -29,7 +29,6 @@ static const char * const backends[] = {
> > #if IS_ENABLED(CONFIG_CRYPTO_ZSTD)
> > "zstd",
> > #endif
> > - NULL
> > };
> >
> > static void zcomp_strm_free(struct zcomp_strm *zstrm)
> > @@ -67,7 +66,7 @@ bool zcomp_available_algorithm(const char *comp)
> > {
> > int i;
> >
> > - i = __sysfs_match_string(backends, -1, comp);
> > + i = sysfs_match_string(backends, comp);
> > if (i >= 0)
> > return true;
> >
> > @@ -86,9 +85,9 @@ ssize_t zcomp_available_show(const char *comp, char *buf)
> > {
> > bool known_algorithm = false;
> > ssize_t sz = 0;
> > - int i = 0;
> > + int i;
> >
> > - for (; backends[i]; i++) {
> > + for (i = 0; i < ARRAY_SIZE(backends); i++) {
> > if (!strcmp(comp, backends[i])) {
> > known_algorithm = true;
> > sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2,
> > --
> > 2.25.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list
2020-04-15 14:47 ` Andy Shevchenko
2020-05-06 12:43 ` Andy Shevchenko
@ 2020-05-08 5:30 ` Minchan Kim
2020-05-08 10:08 ` Andy Shevchenko
1 sibling, 1 reply; 5+ messages in thread
From: Minchan Kim @ 2020-05-08 5:30 UTC (permalink / raw)
To: Andy Shevchenko; +Cc: Nitin Gupta, Sergey Senozhatsky, linux-block, Jens Axboe
On Wed, Apr 15, 2020 at 05:47:47PM +0300, Andy Shevchenko wrote:
> On Mon, Mar 23, 2020 at 07:50:08PM +0200, Andy Shevchenko wrote:
> > Instead of keeping NULL terminated array switch to use ARRAY_SIZE()
> > which helps to further clean up.
>
> Any comments on this?
Acked-by: Minchan Kim <minchan@kernel.org>
Sorry for the late. I lost this patch in my mail box. Could you resend
this patch with Ccing Andrew Morton and Sergey Senozhatsky with me?
Thanks.
>
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > drivers/block/zram/zcomp.c | 7 +++----
> > 1 file changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/block/zram/zcomp.c b/drivers/block/zram/zcomp.c
> > index 1a8564a79d8d..e78e7a2ccfd5 100644
> > --- a/drivers/block/zram/zcomp.c
> > +++ b/drivers/block/zram/zcomp.c
> > @@ -29,7 +29,6 @@ static const char * const backends[] = {
> > #if IS_ENABLED(CONFIG_CRYPTO_ZSTD)
> > "zstd",
> > #endif
> > - NULL
> > };
> >
> > static void zcomp_strm_free(struct zcomp_strm *zstrm)
> > @@ -67,7 +66,7 @@ bool zcomp_available_algorithm(const char *comp)
> > {
> > int i;
> >
> > - i = __sysfs_match_string(backends, -1, comp);
> > + i = sysfs_match_string(backends, comp);
> > if (i >= 0)
> > return true;
> >
> > @@ -86,9 +85,9 @@ ssize_t zcomp_available_show(const char *comp, char *buf)
> > {
> > bool known_algorithm = false;
> > ssize_t sz = 0;
> > - int i = 0;
> > + int i;
> >
> > - for (; backends[i]; i++) {
> > + for (i = 0; i < ARRAY_SIZE(backends); i++) {
> > if (!strcmp(comp, backends[i])) {
> > known_algorithm = true;
> > sz += scnprintf(buf + sz, PAGE_SIZE - sz - 2,
> > --
> > 2.25.1
> >
>
> --
> With Best Regards,
> Andy Shevchenko
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list
2020-05-08 5:30 ` Minchan Kim
@ 2020-05-08 10:08 ` Andy Shevchenko
0 siblings, 0 replies; 5+ messages in thread
From: Andy Shevchenko @ 2020-05-08 10:08 UTC (permalink / raw)
To: Minchan Kim; +Cc: Nitin Gupta, Sergey Senozhatsky, linux-block, Jens Axboe
On Thu, May 07, 2020 at 10:30:40PM -0700, Minchan Kim wrote:
> On Wed, Apr 15, 2020 at 05:47:47PM +0300, Andy Shevchenko wrote:
> > On Mon, Mar 23, 2020 at 07:50:08PM +0200, Andy Shevchenko wrote:
> > > Instead of keeping NULL terminated array switch to use ARRAY_SIZE()
> > > which helps to further clean up.
> >
> > Any comments on this?
>
> Acked-by: Minchan Kim <minchan@kernel.org>
Thanks!
> Sorry for the late. I lost this patch in my mail box. Could you resend
> this patch with Ccing Andrew Morton and Sergey Senozhatsky with me?
Done.
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-08 10:08 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-03-23 17:50 [PATCH v1] zcomp: Use ARRAY_SIZE() for backends list Andy Shevchenko
2020-04-15 14:47 ` Andy Shevchenko
2020-05-06 12:43 ` Andy Shevchenko
2020-05-08 5:30 ` Minchan Kim
2020-05-08 10:08 ` Andy Shevchenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).