From: Alasdair G Kergon <agk@redhat.com>
To: Kjetil Orbekk <kj@orbekk.com>
Cc: Alasdair Kergon <agk@redhat.com>,
Mike Snitzer <snitzer@redhat.com>,
dm-devel@redhat.com, linux-block@vger.kernel.org,
harshads@google.com, Khazhismel Kumykov <khazhy@google.com>
Subject: Re: [PATCH] dm: track io errors per mapped device
Date: Fri, 8 May 2020 01:18:25 +0100 [thread overview]
Message-ID: <20200508001825.GC22266@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20200507230532.5733-1-kj@orbekk.com>
On Thu, May 07, 2020 at 07:05:33PM -0400, Kjetil Orbekk wrote:
> This will track ioerr_cnt on all dm targets and expose it as
> <device>/dm/ioerr_cnt.
How do you propose to use this?
What are you trying to measure and why?
- How exact must the number be to meet your requirements?
Or to put it another way, do you need to know the exact number you are
exposing, or do you derive something else from this which could also be
derived from an alternative number?
In particular, given the way we split and clone and stack devices (so
there may be an element of multiplication), and reload tables (so
existing values might become irrelevant), did you consider alternative
semantics before selecting this approach?
(Or to put it another way, is there a need to reset it or track
the value since the last resume?)
(Documentation is also needed - which ought to explain the semantics
and how the observed values interact with the use of device-mapper
features.)
Alasdair
next prev parent reply other threads:[~2020-05-08 0:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 23:05 [PATCH] dm: track io errors per mapped device Kjetil Orbekk
2020-05-08 0:18 ` Alasdair G Kergon [this message]
2020-05-08 19:18 ` kj
2020-05-08 1:12 ` Chaitanya Kulkarni
2020-05-08 19:22 ` kj
2020-05-08 21:09 ` Mike Snitzer
2020-05-09 16:01 ` kj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200508001825.GC22266@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=harshads@google.com \
--cc=khazhy@google.com \
--cc=kj@orbekk.com \
--cc=linux-block@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).