* [PATCH v2] block: blk-mq.c: fix @at_head kernel-doc warning
@ 2020-08-16 23:39 Randy Dunlap
2020-08-16 23:50 ` Jens Axboe
0 siblings, 1 reply; 3+ messages in thread
From: Randy Dunlap @ 2020-08-16 23:39 UTC (permalink / raw)
To: linux-kernel
Cc: Randy Dunlap, André Almeida, Jens Axboe, Ming Lei, linux-block
Fix a new kernel-doc warning in block/blk-mq.c:
../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert'
Fixes: 01e99aeca397 ("blk-mq: insert passthrough request into hctx->dispatch directly")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: André Almeida <andrealmeid@collabora.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Ming Lei <ming.lei@redhat.com>
Cc: linux-block@vger.kernel.org
---
v2: correct Fixes: Commit-ID + Cc: to author.
block/blk-mq.c | 1 +
1 file changed, 1 insertion(+)
--- lnx-59-rc1.orig/block/blk-mq.c
+++ lnx-59-rc1/block/blk-mq.c
@@ -1834,6 +1834,7 @@ void __blk_mq_insert_request(struct blk_
/**
* blk_mq_request_bypass_insert - Insert a request at dispatch list.
* @rq: Pointer to request to be inserted.
+ * @at_head: true if the request should be inserted at the head of the list.
* @run_queue: If we should run the hardware queue after inserting the request.
*
* Should only be used carefully, when the caller knows we want to
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] block: blk-mq.c: fix @at_head kernel-doc warning
2020-08-16 23:39 [PATCH v2] block: blk-mq.c: fix @at_head kernel-doc warning Randy Dunlap
@ 2020-08-16 23:50 ` Jens Axboe
2020-08-16 23:56 ` Randy Dunlap
0 siblings, 1 reply; 3+ messages in thread
From: Jens Axboe @ 2020-08-16 23:50 UTC (permalink / raw)
To: Randy Dunlap, linux-kernel; +Cc: André Almeida, Ming Lei, linux-block
On 8/16/20 4:39 PM, Randy Dunlap wrote:
> Fix a new kernel-doc warning in block/blk-mq.c:
>
> ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert'
Replaced the previous one - and since I was doing that anyway, I removed
the 'new' from the commit message. Looks like it was from 5.6, so not
what I'd call new.
--
Jens Axboe
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] block: blk-mq.c: fix @at_head kernel-doc warning
2020-08-16 23:50 ` Jens Axboe
@ 2020-08-16 23:56 ` Randy Dunlap
0 siblings, 0 replies; 3+ messages in thread
From: Randy Dunlap @ 2020-08-16 23:56 UTC (permalink / raw)
To: Jens Axboe, linux-kernel; +Cc: André Almeida, Ming Lei, linux-block
On 8/16/20 4:50 PM, Jens Axboe wrote:
> On 8/16/20 4:39 PM, Randy Dunlap wrote:
>> Fix a new kernel-doc warning in block/blk-mq.c:
>>
>> ../block/blk-mq.c:1844: warning: Function parameter or member 'at_head' not described in 'blk_mq_request_bypass_insert'
>
> Replaced the previous one - and since I was doing that anyway, I removed
> the 'new' from the commit message. Looks like it was from 5.6, so not
> what I'd call new.
Yes, I just hadn't seen it before and I check pretty carefully.
thanks.
--
~Randy
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-08-16 23:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-08-16 23:39 [PATCH v2] block: blk-mq.c: fix @at_head kernel-doc warning Randy Dunlap
2020-08-16 23:50 ` Jens Axboe
2020-08-16 23:56 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).