* [PATCH] block: Fix an error handling in add_partition
@ 2021-01-16 7:27 Dinghao Liu
2021-01-16 8:18 ` Chaitanya Kulkarni
0 siblings, 1 reply; 6+ messages in thread
From: Dinghao Liu @ 2021-01-16 7:27 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Jens Axboe, Hannes Reinecke, Jan Kara, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
Once we have called device_initialize(), we should
use put_device() to give up the reference on error,
just like what we have done on failure of device_add().
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
block/partitions/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
err = blk_alloc_devt(bdev, &devt);
if (err)
- goto out_bdput;
+ goto out_put;
pdev->devt = devt;
/* delay uevent until 'holders' subdir is created */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix an error handling in add_partition
2021-01-16 7:27 [PATCH] block: Fix an error handling in add_partition Dinghao Liu
@ 2021-01-16 8:18 ` Chaitanya Kulkarni
2021-01-16 11:05 ` dinghao.liu
0 siblings, 1 reply; 6+ messages in thread
From: Chaitanya Kulkarni @ 2021-01-16 8:18 UTC (permalink / raw)
To: Dinghao Liu, kjlu
Cc: Jens Axboe, Hannes Reinecke, Jan Kara, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
On 1/15/21 11:34 PM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should
> use put_device() to give up the reference on error,
> just like what we have done on failure of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Please consider having following commit message, since above
commit message is looking odd from what we have in the tree :-
Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().
Also have you tested this patch with the with generating appropriate error ?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Re: [PATCH] block: Fix an error handling in add_partition
2021-01-16 8:18 ` Chaitanya Kulkarni
@ 2021-01-16 11:05 ` dinghao.liu
0 siblings, 0 replies; 6+ messages in thread
From: dinghao.liu @ 2021-01-16 11:05 UTC (permalink / raw)
To: Chaitanya Kulkarni
Cc: kjlu, Jens Axboe, Hannes Reinecke, Jan Kara, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
> On 1/15/21 11:34 PM, Dinghao Liu wrote:
> > Once we have called device_initialize(), we should
> > use put_device() to give up the reference on error,
> > just like what we have done on failure of device_add().
> >
> > Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
> Please consider having following commit message, since above
> commit message is looking odd from what we have in the tree :-
>
>
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
Thanks for this suggestion!
>
> Also have you tested this patch with the with generating appropriate error ?
>
No, this problem is found through comparing existing source code.
Regards,
Dinghao
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] block: Fix an error handling in add_partition
@ 2021-01-17 8:50 Dinghao Liu
2021-01-20 10:05 ` Christoph Hellwig
2021-01-25 4:36 ` Jens Axboe
0 siblings, 2 replies; 6+ messages in thread
From: Dinghao Liu @ 2021-01-17 8:50 UTC (permalink / raw)
To: dinghao.liu, kjlu
Cc: Jens Axboe, Jan Kara, Hannes Reinecke, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
Once we have called device_initialize(), we should use put_device() to
give up the reference on error, just like what we have done on failure
of device_add().
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
---
Changelog:
v2: - Refine commit message.
---
block/partitions/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/partitions/core.c b/block/partitions/core.c
index e7d776db803b..23460cee9de5 100644
--- a/block/partitions/core.c
+++ b/block/partitions/core.c
@@ -384,7 +384,7 @@ static struct block_device *add_partition(struct gendisk *disk, int partno,
err = blk_alloc_devt(bdev, &devt);
if (err)
- goto out_bdput;
+ goto out_put;
pdev->devt = devt;
/* delay uevent until 'holders' subdir is created */
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix an error handling in add_partition
2021-01-17 8:50 Dinghao Liu
@ 2021-01-20 10:05 ` Christoph Hellwig
2021-01-25 4:36 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Christoph Hellwig @ 2021-01-20 10:05 UTC (permalink / raw)
To: Dinghao Liu
Cc: kjlu, Jens Axboe, Jan Kara, Hannes Reinecke, Johannes Thumshirn,
Ming Lei, linux-block, linux-kernel
On Sun, Jan 17, 2021 at 04:50:17PM +0800, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
>
> Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] block: Fix an error handling in add_partition
2021-01-17 8:50 Dinghao Liu
2021-01-20 10:05 ` Christoph Hellwig
@ 2021-01-25 4:36 ` Jens Axboe
1 sibling, 0 replies; 6+ messages in thread
From: Jens Axboe @ 2021-01-25 4:36 UTC (permalink / raw)
To: Dinghao Liu, kjlu
Cc: Jan Kara, Hannes Reinecke, Johannes Thumshirn, Ming Lei,
linux-block, linux-kernel
On 1/17/21 1:50 AM, Dinghao Liu wrote:
> Once we have called device_initialize(), we should use put_device() to
> give up the reference on error, just like what we have done on failure
> of device_add().
Applied for 5.11, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2021-01-25 4:36 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-01-16 7:27 [PATCH] block: Fix an error handling in add_partition Dinghao Liu
2021-01-16 8:18 ` Chaitanya Kulkarni
2021-01-16 11:05 ` dinghao.liu
2021-01-17 8:50 Dinghao Liu
2021-01-20 10:05 ` Christoph Hellwig
2021-01-25 4:36 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).