From: Daniel Wagner <dwagner@suse.de>
To: Bart Van Assche <bvanassche@acm.org>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
"Martin K . Petersen" <martin.petersen@oracle.com>,
Shin'ichiro Kawasaki <shinichiro.kawasaki@wdc.com>,
Ming Lei <ming.lei@redhat.com>, Hannes Reinecke <hare@suse.de>,
Johannes Thumshirn <johannes.thumshirn@wdc.com>,
John Garry <john.garry@huawei.com>,
Khazhy Kumykov <khazhy@google.com>
Subject: Re: [PATCH v6 2/5] blk-mq: Introduce atomic variants of blk_mq_(all_tag|tagset_busy)_iter
Date: Wed, 21 Apr 2021 09:25:26 +0200 [thread overview]
Message-ID: <20210421072526.vsimzcgz2ncgiug3@beryllium.lan> (raw)
In-Reply-To: <3a7d44c5-cf67-3d74-49e9-93f83e6eba3c@acm.org>
On Tue, Apr 20, 2021 at 02:35:53PM -0700, Bart Van Assche wrote:
> On 4/13/21 12:50 AM, Daniel Wagner wrote:
> > Maybe you could also annotate blk_mq_all_tag_iter() with a
> > might_sleep(). This would help to find API abusers more easily.
>
> Hmm ... my understanding is that blk_mq_all_tag_iter() does not sleep
> since that function does not sleep itself and since the only caller of
> blk_mq_all_tag_iter() callers passes a callback function that does not
> sleep?
Yes, you are right. I read the documentation and assumed a might_sleep()
would be missing.
next prev parent reply other threads:[~2021-04-21 7:25 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-06 21:49 [PATCH v6 0/5] blk-mq: Fix a race between iterating over requests and freeing requests Bart Van Assche
2021-04-06 21:49 ` [PATCH v6 1/5] blk-mq: Move the elevator_exit() definition Bart Van Assche
2021-04-07 15:36 ` John Garry
2021-04-20 21:30 ` Bart Van Assche
2021-04-13 7:44 ` Daniel Wagner
2021-04-06 21:49 ` [PATCH v6 2/5] blk-mq: Introduce atomic variants of blk_mq_(all_tag|tagset_busy)_iter Bart Van Assche
2021-04-07 16:57 ` John Garry
2021-04-07 18:42 ` Bart Van Assche
2021-04-08 12:48 ` John Garry
2021-04-08 16:12 ` Bart Van Assche
2021-04-08 16:35 ` John Garry
2021-04-13 7:50 ` Daniel Wagner
2021-04-20 21:35 ` Bart Van Assche
2021-04-21 7:25 ` Daniel Wagner [this message]
2021-04-06 21:49 ` [PATCH v6 3/5] blk-mq: Fix races between iterating over requests and freeing requests Bart Van Assche
2021-04-07 0:02 ` Khazhy Kumykov
2021-04-07 21:54 ` Bart Van Assche
2021-04-20 21:41 ` Bart Van Assche
2021-04-06 21:49 ` [PATCH v6 4/5] blk-mq: Make it safe to use RCU to iterate over blk_mq_tag_set.tag_list Bart Van Assche
2021-04-06 21:49 ` [PATCH v6 5/5] blk-mq: Fix races between blk_mq_update_nr_hw_queues() and iterating over tags Bart Van Assche
2021-04-07 0:04 ` Khazhy Kumykov
2021-04-08 6:45 ` [PATCH v6 0/5] blk-mq: Fix a race between iterating over requests and freeing requests Shinichiro Kawasaki
2021-04-20 21:55 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210421072526.vsimzcgz2ncgiug3@beryllium.lan \
--to=dwagner@suse.de \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=johannes.thumshirn@wdc.com \
--cc=john.garry@huawei.com \
--cc=khazhy@google.com \
--cc=linux-block@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=shinichiro.kawasaki@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).