From: Christoph Hellwig <hch@infradead.org>
To: Ming Lei <ming.lei@redhat.com>
Cc: Jens Axboe <axboe@kernel.dk>,
linux-block@vger.kernel.org, Bart Van Assche <bvanassche@acm.org>,
Hannes Reinecke <hare@suse.de>,
John Garry <john.garry@huawei.com>,
David Jeffery <djeffery@redhat.com>
Subject: Re: [PATCH V5 1/4] block: avoid double io accounting for flush request
Date: Thu, 6 May 2021 07:44:19 +0100 [thread overview]
Message-ID: <20210506064419.GB328487@infradead.org> (raw)
In-Reply-To: <20210505145855.174127-2-ming.lei@redhat.com>
On Wed, May 05, 2021 at 10:58:52PM +0800, Ming Lei wrote:
> For flush request, rq->end_io() may be called two times, one is from
> timeout handling(blk_mq_check_expired()), another is from normal
> completion(__blk_mq_end_request()).
>
> Move blk_account_io_flush() after flush_rq->ref drops to zero, so
> io accounting can be done just once for flush request.
>
> Fixes: b68663186577 ("block: add iostat counters for flush requests")
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
> Tested-by: John Garry <john.garry@huawei.com>
> Signed-off-by: Ming Lei <ming.lei@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
Alhought while reviewing this I have to say that the flush code is
one hard to follow mess, and the extra reference doesn't help..
next prev parent reply other threads:[~2021-05-06 6:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-05 14:58 [PATCH V5 0/4] blk-mq: fix request UAF related with iterating over tagset requests Ming Lei
2021-05-05 14:58 ` [PATCH V5 1/4] block: avoid double io accounting for flush request Ming Lei
2021-05-06 6:44 ` Christoph Hellwig [this message]
2021-05-05 14:58 ` [PATCH V5 2/4] blk-mq: grab rq->refcount before calling ->fn in blk_mq_tagset_busy_iter Ming Lei
2021-05-06 6:54 ` Christoph Hellwig
2021-05-06 7:30 ` Ming Lei
2021-05-05 14:58 ` [PATCH V5 3/4] blk-mq: clear stale request in tags->rq[] before freeing one request pool Ming Lei
2021-05-06 7:12 ` Christoph Hellwig
2021-05-06 7:34 ` Ming Lei
2021-05-06 12:18 ` Christoph Hellwig
2021-05-06 13:38 ` Ming Lei
2021-05-07 6:57 ` Christoph Hellwig
2021-05-07 7:30 ` Ming Lei
2021-05-06 14:51 ` Bart Van Assche
2021-05-07 0:11 ` Ming Lei
2021-05-07 1:10 ` Bart Van Assche
2021-05-07 2:05 ` Ming Lei
2021-05-07 3:16 ` Bart Van Assche
2021-05-07 6:31 ` Ming Lei
2021-05-07 6:52 ` Christoph Hellwig
2021-05-08 2:02 ` Bart Van Assche
2021-05-06 15:02 ` Bart Van Assche
2021-05-07 0:13 ` Ming Lei
2021-05-07 1:11 ` Bart Van Assche
2021-05-07 2:06 ` Ming Lei
2021-05-05 14:58 ` [PATCH V5 4/4] blk-mq: clearing flush request reference in tags->rqs[] Ming Lei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210506064419.GB328487@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=djeffery@redhat.com \
--cc=hare@suse.de \
--cc=john.garry@huawei.com \
--cc=linux-block@vger.kernel.org \
--cc=ming.lei@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).