From: Changheun Lee <nanich.lee@samsung.com>
To: Johannes.Thumshirn@wdc.com, alex_y_xu@yahoo.ca,
asml.silence@gmail.com, axboe@kernel.dk, bgoncalv@redhat.com,
jejb@linux.ibm.com, martin.petersen@oracle.com,
cang@codeaurora.org, avri.altman@wdc.com,
alim.akhtar@samsung.com, bvanassche@acm.org,
damien.lemoal@wdc.com, gregkh@linuxfoundation.org,
hch@infradead.org, jaegeuk@kernel.org,
linux-block@vger.kernel.org, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, ming.lei@redhat.com,
osandov@fb.com, patchwork-bot@kernel.org, tj@kernel.org,
tom.leiming@gmail.com, yi.zhang@redhat.com
Cc: jisoo2146.oh@samsung.com, junho89.kim@samsung.com,
mj0123.lee@samsung.com, seunghwan.hyun@samsung.com,
sookwan7.kim@samsung.com, woosung2.lee@samsung.com,
yt0928.kim@samsung.com, Changheun Lee <nanich.lee@samsung.com>
Subject: [PATCH v12 2/3] blk-sysfs: add max_bio_bytes
Date: Fri, 4 Jun 2021 14:03:23 +0900 [thread overview]
Message-ID: <20210604050324.28670-3-nanich.lee@samsung.com> (raw)
In-Reply-To: <20210604050324.28670-1-nanich.lee@samsung.com>
Add max_bio_bytes block sysfs node to show current maximum bio size.
Signed-off-by: Changheun Lee <nanich.lee@samsung.com>
---
Documentation/ABI/testing/sysfs-block | 10 ++++++++++
Documentation/block/queue-sysfs.rst | 7 +++++++
block/blk-sysfs.c | 7 +++++++
3 files changed, 24 insertions(+)
diff --git a/Documentation/ABI/testing/sysfs-block b/Documentation/ABI/testing/sysfs-block
index e34cdeeeb9d4..8c8a793c04b4 100644
--- a/Documentation/ABI/testing/sysfs-block
+++ b/Documentation/ABI/testing/sysfs-block
@@ -316,3 +316,13 @@ Description:
does not complete in this time then the block driver timeout
handler is invoked. That timeout handler can decide to retry
the request, to fail it or to start a device recovery strategy.
+
+What: /sys/block/<disk>/queue/max_bio_bytes
+Date: June 2021
+Contact: Changheun Lee <nanich.lee@samsung.com>
+Description:
+ max_bio_bytes is the maximum bio size to be submitted in bytes.
+ It shows current maximum bio size, and bio size to be submitted
+ will be limited with this. Default value is UINT_MAX, and
+ the minimum value is 1MB. 1MB(=BIO_MAX_VECS * PAGE_SIZE) is
+ legacy maximum bio size.
diff --git a/Documentation/block/queue-sysfs.rst b/Documentation/block/queue-sysfs.rst
index 4dc7f0d499a8..90af56899aa9 100644
--- a/Documentation/block/queue-sysfs.rst
+++ b/Documentation/block/queue-sysfs.rst
@@ -286,4 +286,11 @@ sequential zones of zoned block devices (devices with a zoned attributed
that reports "host-managed" or "host-aware"). This value is always 0 for
regular block devices.
+max_bio_bytes (RO)
+---------------------------
+This is the maximum number of bytes that bio size to be submitted will be
+limited. A value of 4,294,967,295(UINT_MAX) means no limit of bio size,
+and it's a default value. The minimum value is 1MB. It's legacy maximum
+bio size. (=BIO_MAX_VECS * PAGE_SIZE)
+
Jens Axboe <jens.axboe@oracle.com>, February 2009
diff --git a/block/blk-sysfs.c b/block/blk-sysfs.c
index e03bedf180ab..c4cae6bbcb3b 100644
--- a/block/blk-sysfs.c
+++ b/block/blk-sysfs.c
@@ -108,6 +108,11 @@ queue_ra_store(struct request_queue *q, const char *page, size_t count)
return ret;
}
+static ssize_t queue_max_bio_bytes_show(struct request_queue *q, char *page)
+{
+ return queue_var_show(q->limits.max_bio_bytes, (page));
+}
+
static ssize_t queue_max_sectors_show(struct request_queue *q, char *page)
{
int max_sectors_kb = queue_max_sectors(q) >> 1;
@@ -577,6 +582,7 @@ static struct queue_sysfs_entry _prefix##_entry = { \
QUEUE_RW_ENTRY(queue_requests, "nr_requests");
QUEUE_RW_ENTRY(queue_ra, "read_ahead_kb");
+QUEUE_RO_ENTRY(queue_max_bio_bytes, "max_bio_bytes");
QUEUE_RW_ENTRY(queue_max_sectors, "max_sectors_kb");
QUEUE_RO_ENTRY(queue_max_hw_sectors, "max_hw_sectors_kb");
QUEUE_RO_ENTRY(queue_max_segments, "max_segments");
@@ -635,6 +641,7 @@ QUEUE_RW_ENTRY(queue_stable_writes, "stable_writes");
static struct attribute *queue_attrs[] = {
&queue_requests_entry.attr,
&queue_ra_entry.attr,
+ &queue_max_bio_bytes_entry.attr,
&queue_max_hw_sectors_entry.attr,
&queue_max_sectors_entry.attr,
&queue_max_segments_entry.attr,
--
2.29.0
next prev parent reply other threads:[~2021-06-04 5:22 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210604052157epcas1p2e5eebb52d08b06174696290e11fdd5a4@epcas1p2.samsung.com>
2021-06-04 5:03 ` [PATCH v12 0/3] bio: control bio max size Changheun Lee
[not found] ` <CGME20210604052159epcas1p4370bee98aad882ab335dda1565db94fb@epcas1p4.samsung.com>
2021-06-04 5:03 ` [PATCH v12 1/3] " Changheun Lee
2021-06-04 7:24 ` Damien Le Moal
[not found] ` <CGME20210604075331epcas1p13bb57f9ddfc7b112dec1ba8cf40fdc74@epcas1p1.samsung.com>
2021-06-04 7:34 ` Changheun Lee
2021-06-04 8:01 ` Damien Le Moal
[not found] ` <CGME20210604094209epcas1p26368dd18011bb2761529432cf2656a9f@epcas1p2.samsung.com>
2021-06-04 9:23 ` Changheun Lee
2021-06-04 14:52 ` Bart Van Assche
2021-06-07 6:35 ` Christoph Hellwig
2021-06-07 16:46 ` Bart Van Assche
2021-06-08 5:22 ` Christoph Hellwig
2021-06-07 6:32 ` Christoph Hellwig
[not found] ` <CGME20210607110122epcas1p4557bcbc7abac791f2557cc0d317214fd@epcas1p4.samsung.com>
2021-06-07 10:42 ` Changheun Lee
[not found] ` <CGME20210604052200epcas1p10754a3187476a0fcbfcc89c103a6d436@epcas1p1.samsung.com>
2021-06-04 5:03 ` Changheun Lee [this message]
[not found] ` <CGME20210604052201epcas1p41a27660b20d70b7fc4295c8f131d33ce@epcas1p4.samsung.com>
2021-06-04 5:03 ` [PATCH v12 3/3] ufs: set max_bio_bytes with queue max sectors Changheun Lee
2021-06-04 16:11 ` Bart Van Assche
[not found] ` <CGME20210607094031epcas1p1f4a9ee01eaa4652ba0e8eb6a4964c952@epcas1p1.samsung.com>
2021-06-07 9:21 ` Changheun Lee
2021-06-04 6:41 ` [PATCH v12 0/3] bio: control bio max size Can Guo
2021-06-04 16:13 ` Bart Van Assche
[not found] ` <CGME20210607101609epcas1p392324f6d215e329d632a615c4b1adf4c@epcas1p3.samsung.com>
2021-06-07 9:57 ` Changheun Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210604050324.28670-3-nanich.lee@samsung.com \
--to=nanich.lee@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=alex_y_xu@yahoo.ca \
--cc=alim.akhtar@samsung.com \
--cc=asml.silence@gmail.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=bgoncalv@redhat.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=damien.lemoal@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jisoo2146.oh@samsung.com \
--cc=junho89.kim@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mj0123.lee@samsung.com \
--cc=osandov@fb.com \
--cc=patchwork-bot@kernel.org \
--cc=seunghwan.hyun@samsung.com \
--cc=sookwan7.kim@samsung.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=woosung2.lee@samsung.com \
--cc=yi.zhang@redhat.com \
--cc=yt0928.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).