From: Changheun Lee <nanich.lee@samsung.com>
To: bvanassche@acm.org
Cc: Johannes.Thumshirn@wdc.com, alex_y_xu@yahoo.ca,
alim.akhtar@samsung.com, asml.silence@gmail.com,
avri.altman@wdc.com, axboe@kernel.dk, bgoncalv@redhat.com,
cang@codeaurora.org, damien.lemoal@wdc.com,
gregkh@linuxfoundation.org, hch@infradead.org,
jaegeuk@kernel.org, jejb@linux.ibm.com, jisoo2146.oh@samsung.com,
junho89.kim@samsung.com, linux-block@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
martin.petersen@oracle.com, ming.lei@redhat.com,
mj0123.lee@samsung.com, nanich.lee@samsung.com, osandov@fb.com,
patchwork-bot@kernel.org, seunghwan.hyun@samsung.com,
sookwan7.kim@samsung.com, tj@kernel.org, tom.leiming@gmail.com,
woosung2.lee@samsung.com, yi.zhang@redhat.com,
yt0928.kim@samsung.com
Subject: Re: [PATCH v12 0/3] bio: control bio max size
Date: Mon, 7 Jun 2021 18:57:32 +0900 [thread overview]
Message-ID: <20210607095732.16896-1-nanich.lee@samsung.com> (raw)
In-Reply-To: <9e1c43a8-1c6d-95c6-ce4c-34ac194b9022@acm.org>
> On 6/3/21 10:03 PM, Changheun Lee wrote:
> > bio size can grow up to 4GB after muli-page bvec has been enabled.
> > But sometimes large size of bio would lead to inefficient behaviors.
> > Control of bio max size will be helpful to improve inefficiency.
> >
> > blk_queue_max_bio_bytes() is added to enable be set the max_bio_bytes in
> > each driver layer. And max_bio_bytes sysfs is added to show current
> > max_bio_bytes for each request queue.
> > bio size can be controlled via max_bio_bytes.
>
> Where is the version history for this patch series?
Sorry. I didn't know about it. I'll do next. Thank you for advise.
>
> Has this patch series been tested in combination with dm-crypt?
This patch has been tested in android device. And dm-crypt on the top of scsi
has tested with below scsi modification in VM too.
@@ -1837,6 +1837,8 @@ void __scsi_init_queue(struct Scsi_Host *shost, struct request_queue *q)
blk_queue_virt_boundary(q, shost->virt_boundary_mask);
dma_set_max_seg_size(dev, queue_max_segment_size(q));
+ blk_queue_max_bio_bytes(q, queue_max_sectors(q) << SECTOR_SHIFT);
+
/*
* Set a reasonable default alignment: The larger of 32-byte (dword),
* which is a common minimum for HBAs, and the minimum DMA alignment,
>
> Bart.
>
Thank you,
Changheun Lee
prev parent reply other threads:[~2021-06-07 10:16 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20210604052157epcas1p2e5eebb52d08b06174696290e11fdd5a4@epcas1p2.samsung.com>
2021-06-04 5:03 ` [PATCH v12 0/3] bio: control bio max size Changheun Lee
[not found] ` <CGME20210604052159epcas1p4370bee98aad882ab335dda1565db94fb@epcas1p4.samsung.com>
2021-06-04 5:03 ` [PATCH v12 1/3] " Changheun Lee
2021-06-04 7:24 ` Damien Le Moal
[not found] ` <CGME20210604075331epcas1p13bb57f9ddfc7b112dec1ba8cf40fdc74@epcas1p1.samsung.com>
2021-06-04 7:34 ` Changheun Lee
2021-06-04 8:01 ` Damien Le Moal
[not found] ` <CGME20210604094209epcas1p26368dd18011bb2761529432cf2656a9f@epcas1p2.samsung.com>
2021-06-04 9:23 ` Changheun Lee
2021-06-04 14:52 ` Bart Van Assche
2021-06-07 6:35 ` Christoph Hellwig
2021-06-07 16:46 ` Bart Van Assche
2021-06-08 5:22 ` Christoph Hellwig
2021-06-07 6:32 ` Christoph Hellwig
[not found] ` <CGME20210607110122epcas1p4557bcbc7abac791f2557cc0d317214fd@epcas1p4.samsung.com>
2021-06-07 10:42 ` Changheun Lee
[not found] ` <CGME20210604052200epcas1p10754a3187476a0fcbfcc89c103a6d436@epcas1p1.samsung.com>
2021-06-04 5:03 ` [PATCH v12 2/3] blk-sysfs: add max_bio_bytes Changheun Lee
[not found] ` <CGME20210604052201epcas1p41a27660b20d70b7fc4295c8f131d33ce@epcas1p4.samsung.com>
2021-06-04 5:03 ` [PATCH v12 3/3] ufs: set max_bio_bytes with queue max sectors Changheun Lee
2021-06-04 16:11 ` Bart Van Assche
[not found] ` <CGME20210607094031epcas1p1f4a9ee01eaa4652ba0e8eb6a4964c952@epcas1p1.samsung.com>
2021-06-07 9:21 ` Changheun Lee
2021-06-04 6:41 ` [PATCH v12 0/3] bio: control bio max size Can Guo
2021-06-04 16:13 ` Bart Van Assche
[not found] ` <CGME20210607101609epcas1p392324f6d215e329d632a615c4b1adf4c@epcas1p3.samsung.com>
2021-06-07 9:57 ` Changheun Lee [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210607095732.16896-1-nanich.lee@samsung.com \
--to=nanich.lee@samsung.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=alex_y_xu@yahoo.ca \
--cc=alim.akhtar@samsung.com \
--cc=asml.silence@gmail.com \
--cc=avri.altman@wdc.com \
--cc=axboe@kernel.dk \
--cc=bgoncalv@redhat.com \
--cc=bvanassche@acm.org \
--cc=cang@codeaurora.org \
--cc=damien.lemoal@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@infradead.org \
--cc=jaegeuk@kernel.org \
--cc=jejb@linux.ibm.com \
--cc=jisoo2146.oh@samsung.com \
--cc=junho89.kim@samsung.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=ming.lei@redhat.com \
--cc=mj0123.lee@samsung.com \
--cc=osandov@fb.com \
--cc=patchwork-bot@kernel.org \
--cc=seunghwan.hyun@samsung.com \
--cc=sookwan7.kim@samsung.com \
--cc=tj@kernel.org \
--cc=tom.leiming@gmail.com \
--cc=woosung2.lee@samsung.com \
--cc=yi.zhang@redhat.com \
--cc=yt0928.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).