From: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
To: linux-block@vger.kernel.org
Cc: axboe@kernel.dk, Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: [PATCH 2/9] loop: use sysfs_emit() in the sysfs sizelimit show
Date: Tue, 22 Jun 2021 16:19:44 -0700 [thread overview]
Message-ID: <20210622231952.5625-3-chaitanya.kulkarni@wdc.com> (raw)
In-Reply-To: <20210622231952.5625-1-chaitanya.kulkarni@wdc.com>
Output defects can exist in sysfs content using sprintf and snprintf.
sprintf does not know the PAGE_SIZE maximum of the temporary buffer
used for outputting sysfs content and it's possible to overrun the
PAGE_SIZE buffer length.
Use a generic sysfs_emit function that knows that the size of the
temporary buffer and ensures that no overrun is done for sizelimit
attribute.
Signed-off-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
---
drivers/block/loop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/loop.c b/drivers/block/loop.c
index 847faa6c48fc..084fa914a399 100644
--- a/drivers/block/loop.c
+++ b/drivers/block/loop.c
@@ -812,7 +812,7 @@ static ssize_t loop_attr_offset_show(struct loop_device *lo, char *buf)
static ssize_t loop_attr_sizelimit_show(struct loop_device *lo, char *buf)
{
- return sprintf(buf, "%llu\n", (unsigned long long)lo->lo_sizelimit);
+ return sysfs_emit(buf, "%llu\n", (unsigned long long)lo->lo_sizelimit);
}
static ssize_t loop_attr_autoclear_show(struct loop_device *lo, char *buf)
--
2.22.1
next prev parent reply other threads:[~2021-06-22 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-22 23:19 [PATCH 0/9] loop: small clenaup Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 1/9] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni
2021-06-22 23:19 ` Chaitanya Kulkarni [this message]
2021-06-22 23:19 ` [PATCH 3/9] loop: use sysfs_emit() in the sysfs autoclear show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 4/9] loop: use sysfs_emit() in the sysfs partscan show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 5/9] loop: use sysfs_emit() in the sysfs dio show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 6/9] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 7/9] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 8/9] loop: remove the extra line in declaration Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 9/9] loop: allow user to set the queue depth Chaitanya Kulkarni
2021-06-22 23:27 ` Bart Van Assche
2021-06-24 4:36 ` Chaitanya Kulkarni
2021-06-24 14:14 ` Bart Van Assche
2021-06-24 22:48 ` Chaitanya Kulkarni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210622231952.5625-3-chaitanya.kulkarni@wdc.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).