linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Bart Van Assche <bvanassche@acm.org>
Cc: "axboe@kernel.dk" <axboe@kernel.dk>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH 9/9] loop: allow user to set the queue depth
Date: Thu, 24 Jun 2021 22:48:20 +0000	[thread overview]
Message-ID: <BYAPR04MB496564636FFF75A921CEBD3386079@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: af677291-d4dd-e3a3-886e-3dc9e3779fd1@acm.org

>> Unfortunately I don't have access to all the applications so I can come
>> up with
>> quantitative data, I can try synthetic applications such as fio.
>>
>> This patch is more on the side of allowing user to change the qd value
>> so they can
>> experiment, making loop qd flexible like other block drivers which loop
>> lacks right now.
> Kernel module parameters are inflexible. If there is agreement that this
> parameter should become configurable it probably should be made
> configurable per loop device instead of introducing a single global
> parameter.

Agree, but it is still better than having a statically assigned value in
the code.

I'll drop this in the V2 version, meanwhile it will be great to have your
review comments on the rest of the series.



      reply	other threads:[~2021-06-24 22:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-22 23:19 [PATCH 0/9] loop: small clenaup Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 1/9] loop: use sysfs_emit() in the sysfs offset show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 2/9] loop: use sysfs_emit() in the sysfs sizelimit show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 3/9] loop: use sysfs_emit() in the sysfs autoclear show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 4/9] loop: use sysfs_emit() in the sysfs partscan show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 5/9] loop: use sysfs_emit() in the sysfs dio show Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 6/9] loop: remove extra variable in lo_fallocate() Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 7/9] loop: remove extra variable in lo_req_flush Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 8/9] loop: remove the extra line in declaration Chaitanya Kulkarni
2021-06-22 23:19 ` [PATCH 9/9] loop: allow user to set the queue depth Chaitanya Kulkarni
2021-06-22 23:27   ` Bart Van Assche
2021-06-24  4:36     ` Chaitanya Kulkarni
2021-06-24 14:14       ` Bart Van Assche
2021-06-24 22:48         ` Chaitanya Kulkarni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=BYAPR04MB496564636FFF75A921CEBD3386079@BYAPR04MB4965.namprd04.prod.outlook.com \
    --to=chaitanya.kulkarni@wdc.com \
    --cc=axboe@kernel.dk \
    --cc=bvanassche@acm.org \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).