* [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset
@ 2021-07-05 9:25 Wang Qing
2021-07-06 2:40 ` Guoqing Jiang
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wang Qing @ 2021-07-05 9:25 UTC (permalink / raw)
To: Josef Bacik, Jens Axboe, Chaitanya Kulkarni, linux-block, nbd,
linux-kernel
Cc: Wang Qing, Guoqing Jiang
Must release the queue before freeing the tagset.
Fixes: 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")
Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
---
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index b7d6637..c383179
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)
if (disk) {
del_gendisk(disk);
- blk_mq_free_tag_set(&nbd->tag_set);
blk_cleanup_disk(disk);
+ blk_mq_free_tag_set(&nbd->tag_set);
}
/*
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-05 9:25 [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset Wang Qing
@ 2021-07-06 2:40 ` Guoqing Jiang
2021-07-06 2:48 ` 王擎
2021-07-06 4:00 ` [PATCH V2] " Guoqing Jiang
2021-07-15 15:29 ` [PATCH] block: " Jens Axboe
2 siblings, 1 reply; 7+ messages in thread
From: Guoqing Jiang @ 2021-07-06 2:40 UTC (permalink / raw)
To: Wang Qing, Josef Bacik, Jens Axboe, Chaitanya Kulkarni,
linux-block, nbd, linux-kernel
On 7/5/21 5:25 PM, Wang Qing wrote:
> Must release the queue before freeing the tagset.
>
> Fixes: 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")
> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
Did syzbot actually test the change?
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
I don't mind you sent it quickly, but pls remove my outdated mail account.
Guoqing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re:Re: [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-06 2:40 ` Guoqing Jiang
@ 2021-07-06 2:48 ` 王擎
0 siblings, 0 replies; 7+ messages in thread
From: 王擎 @ 2021-07-06 2:48 UTC (permalink / raw)
To: Guoqing Jiang
Cc: Josef Bacik, Jens Axboe, Chaitanya Kulkarni, linux-block, nbd,
linux-kernel
>
>On 7/5/21 5:25 PM, Wang Qing wrote:
>> Must release the queue before freeing the tagset.
>>
>> Fixes: 1c99502fae35 ("loop: use blk_mq_alloc_disk and blk_cleanup_disk")
>> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
>
>Did syzbot actually test the change?
Yes, I have initiated the test, and did not report this error again, but still reported other known errors,
so I think the test passed. And this is an obvious problem, it needs to be fixed anyway.
>
>> Signed-off-by: Wang Qing <wangqing@vivo.com>
>> Signed-off-by: Guoqing Jiang <guoqing.jiang@cloud.ionos.com>
>
>I don't mind you sent it quickly, but pls remove my outdated mail account.
Sorry about this, you can re-initiate a patch if you don't mind,
as if you still have one thing to modify.
Qing
>
>Guoqing
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-05 9:25 [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset Wang Qing
2021-07-06 2:40 ` Guoqing Jiang
@ 2021-07-06 4:00 ` Guoqing Jiang
2021-07-06 4:17 ` Christoph Hellwig
2021-07-15 6:55 ` Christoph Hellwig
2021-07-15 15:29 ` [PATCH] block: " Jens Axboe
2 siblings, 2 replies; 7+ messages in thread
From: Guoqing Jiang @ 2021-07-06 4:00 UTC (permalink / raw)
To: josef, axboe, hch, chaitanya.kulkarni; +Cc: linux-block, nbd
From: Wang Qing <wangqing@vivo.com>
We must release the queue before freeing the tagset.
Fixes: 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")
Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
Signed-off-by: Wang Qing <wangqing@vivo.com>
Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
---
V2 changes: Correct the fixes tag and mail address.
drivers/block/nbd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
index b7d663736d35..c38317979f74 100644
--- a/drivers/block/nbd.c
+++ b/drivers/block/nbd.c
@@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)
if (disk) {
del_gendisk(disk);
- blk_mq_free_tag_set(&nbd->tag_set);
blk_cleanup_disk(disk);
+ blk_mq_free_tag_set(&nbd->tag_set);
}
/*
--
2.25.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-06 4:00 ` [PATCH V2] " Guoqing Jiang
@ 2021-07-06 4:17 ` Christoph Hellwig
2021-07-15 6:55 ` Christoph Hellwig
1 sibling, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-07-06 4:17 UTC (permalink / raw)
To: Guoqing Jiang; +Cc: josef, axboe, hch, chaitanya.kulkarni, linux-block, nbd
On Tue, Jul 06, 2021 at 12:00:16PM +0800, Guoqing Jiang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> We must release the queue before freeing the tagset.
>
> Fixes: 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH V2] nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-06 4:00 ` [PATCH V2] " Guoqing Jiang
2021-07-06 4:17 ` Christoph Hellwig
@ 2021-07-15 6:55 ` Christoph Hellwig
1 sibling, 0 replies; 7+ messages in thread
From: Christoph Hellwig @ 2021-07-15 6:55 UTC (permalink / raw)
To: axboe; +Cc: Guoqing Jiang, josef, chaitanya.kulkarni, linux-block, nbd
Jens, can you pick this up?
On Tue, Jul 06, 2021 at 12:00:16PM +0800, Guoqing Jiang wrote:
> From: Wang Qing <wangqing@vivo.com>
>
> We must release the queue before freeing the tagset.
>
> Fixes: 4af5f2e03013 ("nbd: use blk_mq_alloc_disk and blk_cleanup_disk")
> Reported-and-tested-by: syzbot+9ca43ff47167c0ee3466@syzkaller.appspotmail.com
> Signed-off-by: Wang Qing <wangqing@vivo.com>
> Signed-off-by: Guoqing Jiang <jiangguoqing@kylinos.cn>
> ---
> V2 changes: Correct the fixes tag and mail address.
>
> drivers/block/nbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/block/nbd.c b/drivers/block/nbd.c
> index b7d663736d35..c38317979f74 100644
> --- a/drivers/block/nbd.c
> +++ b/drivers/block/nbd.c
> @@ -239,8 +239,8 @@ static void nbd_dev_remove(struct nbd_device *nbd)
>
> if (disk) {
> del_gendisk(disk);
> - blk_mq_free_tag_set(&nbd->tag_set);
> blk_cleanup_disk(disk);
> + blk_mq_free_tag_set(&nbd->tag_set);
> }
>
> /*
> --
> 2.25.1
>
---end quoted text---
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset
2021-07-05 9:25 [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset Wang Qing
2021-07-06 2:40 ` Guoqing Jiang
2021-07-06 4:00 ` [PATCH V2] " Guoqing Jiang
@ 2021-07-15 15:29 ` Jens Axboe
2 siblings, 0 replies; 7+ messages in thread
From: Jens Axboe @ 2021-07-15 15:29 UTC (permalink / raw)
To: Wang Qing, Josef Bacik, Chaitanya Kulkarni, linux-block, nbd,
linux-kernel
Cc: Guoqing Jiang
On 7/5/21 3:25 AM, Wang Qing wrote:
> Must release the queue before freeing the tagset.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2021-07-15 15:30 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-05 9:25 [PATCH] block: nbd: fix order of cleaning up the queue and freeing the tagset Wang Qing
2021-07-06 2:40 ` Guoqing Jiang
2021-07-06 2:48 ` 王擎
2021-07-06 4:00 ` [PATCH V2] " Guoqing Jiang
2021-07-06 4:17 ` Christoph Hellwig
2021-07-15 6:55 ` Christoph Hellwig
2021-07-15 15:29 ` [PATCH] block: " Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).