From: Naohiro Aota <Naohiro.Aota@wdc.com>
To: "hch@infradead.org" <hch@infradead.org>
Cc: "linux-btrfs@vger.kernel.org" <linux-btrfs@vger.kernel.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Jens Axboe <axboe@kernel.dk>, David Sterba <dsterba@suse.com>
Subject: Re: [PATCH v2 2/3] btrfs: fix argument type of btrfs_bio_clone_partial()
Date: Wed, 21 Jul 2021 12:33:43 +0000 [thread overview]
Message-ID: <20210721123342.m2a7mtz5tsvrrreu@naota-xeon> (raw)
In-Reply-To: <YPfAvDXlikV4t3zA@infradead.org>
On Wed, Jul 21, 2021 at 07:37:48AM +0100, Christoph Hellwig wrote:
> On Wed, Jul 21, 2021 at 03:26:59PM +0900, Naohiro Aota wrote:
> > btrfs_bio = btrfs_io_bio(bio);
> > btrfs_io_bio_init(btrfs_bio);
> >
> > - bio_trim(bio, offset >> 9, size >> 9);
> > + bio_trim(bio, (sector_t)offset >> 9, (sector_t)size >> 9);
>
> No need for the casts when shifting down.
Ah, OK. As, I switched the type to "u64", they are actually the same
type anyway.
next prev parent reply other threads:[~2021-07-21 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:26 [PATCH v2 0/3] fix argument type of bio_trim() Naohiro Aota
2021-07-21 6:26 ` [PATCH v2 1/3] block: fix arg " Naohiro Aota
2021-07-21 6:36 ` Christoph Hellwig
2021-07-21 11:47 ` Naohiro Aota
2021-07-21 6:26 ` [PATCH v2 2/3] btrfs: fix argument type of btrfs_bio_clone_partial() Naohiro Aota
2021-07-21 6:37 ` Christoph Hellwig
2021-07-21 12:33 ` Naohiro Aota [this message]
2021-07-21 6:27 ` [PATCH v2 3/3] btrfs: drop unnecessary ASSERT from btrfs_submit_direct() Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210721123342.m2a7mtz5tsvrrreu@naota-xeon \
--to=naohiro.aota@wdc.com \
--cc=axboe@kernel.dk \
--cc=dsterba@suse.com \
--cc=hch@infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).