From: Christoph Hellwig <hch@infradead.org>
To: Naohiro Aota <naohiro.aota@wdc.com>
Cc: linux-btrfs@vger.kernel.org, linux-block@vger.kernel.org,
Jens Axboe <axboe@kernel.dk>, David Sterba <dsterba@suse.com>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>
Subject: Re: [PATCH v2 1/3] block: fix arg type of bio_trim()
Date: Wed, 21 Jul 2021 07:36:05 +0100 [thread overview]
Message-ID: <YPfAVSlYdM+TAe2z@infradead.org> (raw)
In-Reply-To: <6bd02746905e41dfee04f2500d6d15f9b9b73fc9.1626848677.git.naohiro.aota@wdc.com>
On Wed, Jul 21, 2021 at 03:26:58PM +0900, Naohiro Aota wrote:
> +void bio_trim(struct bio *bio, sector_t offset, sector_t size)
> {
> + const sector_t uint_max_sectors = UINT_MAX >> SECTOR_SHIFT;
I'd make this a #define and keep it close to the struct bio definition
named something like BIO_MAX_SECTORS
> +
> + /*
> + * 'bio' is a cloned bio which we need to trim to match the given
> + * offset and size.
> */
This should go into the kernel doc comment.
Something like:
/**
* bio_trim - trim a bio to the given offset and size
* @bio: bio to trim
* @offset: number of sectors to trim from the front of @bio
* @size: size we want to trim @bio to, in sectors
*
* This function is typically used for bios that are cloned and
* submitted to the underlying device in parts.
*/
> + /* sanity check */
> + if (WARN_ON(offset > uint_max_sectors || size > uint_max_sectors ||
> + offset + size > bio->bi_iter.bi_size))
> + return;
No real need for the comment. WARN_ON pretty much implies a sanity
check. I'd make this a WARN_ON_ONCE as otherwise you'll probably
drown in these warnings if they ever hit.
> -extern void bio_trim(struct bio *bio, int offset, int size);
> +extern void bio_trim(struct bio *bio, sector_t offset, sector_t size);
Please drop the extern while you're at it.
next prev parent reply other threads:[~2021-07-21 6:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-21 6:26 [PATCH v2 0/3] fix argument type of bio_trim() Naohiro Aota
2021-07-21 6:26 ` [PATCH v2 1/3] block: fix arg " Naohiro Aota
2021-07-21 6:36 ` Christoph Hellwig [this message]
2021-07-21 11:47 ` Naohiro Aota
2021-07-21 6:26 ` [PATCH v2 2/3] btrfs: fix argument type of btrfs_bio_clone_partial() Naohiro Aota
2021-07-21 6:37 ` Christoph Hellwig
2021-07-21 12:33 ` Naohiro Aota
2021-07-21 6:27 ` [PATCH v2 3/3] btrfs: drop unnecessary ASSERT from btrfs_submit_direct() Naohiro Aota
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YPfAVSlYdM+TAe2z@infradead.org \
--to=hch@infradead.org \
--cc=axboe@kernel.dk \
--cc=chaitanya.kulkarni@wdc.com \
--cc=dsterba@suse.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=naohiro.aota@wdc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).