From: Christoph Hellwig <hch@lst.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Jens Axboe <axboe@kernel.dk>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: please revert the UFS HPB support
Date: Sat, 23 Oct 2021 06:40:29 +0200 [thread overview]
Message-ID: <20211023044029.GA21338@lst.de> (raw)
In-Reply-To: <yq1ilxp68x3.fsf@ca-mkp.ca.oracle.com>
On Fri, Oct 22, 2021 at 09:54:44PM -0400, Martin K. Petersen wrote:
> The series went through 40 iterations on the list prior to being merged.
> I don't recall a better approach to reconcile the HPB model with the
> stack being offered during that process?
>
> As much as I don't like HPB, all the major UFS subsystem stakeholders
> are behind it. The hardware is shipping and various device stacks
> already adopted support for it. At this stage I don't think dropping the
> code is a way forward. I am much more in favor of having a productive
> discussion about how to go about addressing the problems with the
> queuing model...
This is іs not about HPB about a feature beeing a bad idea. I explained
that at least a dozend times, and there's been no sensible counter
arguments to that but it has been merged anyway. (FYI Zoned devices
are the obvious and old answer).
But this implementation is simply completely broken from the block
layer POV and we must not release a kernel with that brokenness in it.
prev parent reply other threads:[~2021-10-23 4:40 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 14:42 please revert the UFS HPB support Christoph Hellwig
2021-10-21 15:13 ` Jens Axboe
2021-10-21 15:15 ` Christoph Hellwig
2021-10-21 15:17 ` Christoph Hellwig
2021-10-21 16:22 ` Bart Van Assche
2021-10-23 15:43 ` James Bottomley
[not found] ` <CGME20211023154316epcas2p208f95cf1e4a87a4b61d2daf1a2b3c725@epcms2p3>
2021-10-25 5:16 ` Daejun Park
2021-10-25 7:07 ` Christoph Hellwig
2021-10-25 11:39 ` James Bottomley
2021-10-23 1:54 ` Martin K. Petersen
2021-10-23 4:40 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211023044029.GA21338@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).