[PATCH] zram: use ATTRIBUTE_GROUPS

[PATCH] zram: use ATTRIBUTE_GROUPS

[Luis Chamberlain]

Embrace ATTRIBUTE_GROUPS to avoid boiler plate code.
This should not introduce any functional changes.

Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
---
 drivers/block/zram/zram_drv.c | 11 ++---------
 1 file changed, 2 insertions(+), 9 deletions(-)

diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
index fcaf2750f68f..268f727f7cba 100644
--- a/drivers/block/zram/zram_drv.c
+++ b/drivers/block/zram/zram_drv.c
@@ -1874,14 +1874,7 @@ static struct attribute *zram_disk_attrs[] = {
 	NULL,
 };
 
-static const struct attribute_group zram_disk_attr_group = {
-	.attrs = zram_disk_attrs,
-};
-
-static const struct attribute_group *zram_disk_attr_groups[] = {
-	&zram_disk_attr_group,
-	NULL,
-};
+ATTRIBUTE_GROUPS(zram_disk);
 
 /*
  * Allocate and initialize new zram device. the function returns
@@ -1953,7 +1946,7 @@ static int zram_add(void)
 		blk_queue_max_write_zeroes_sectors(zram->disk->queue, UINT_MAX);
 
 	blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, zram->disk->queue);
-	device_add_disk(NULL, zram->disk, zram_disk_attr_groups);
+	device_add_disk(NULL, zram->disk, zram_disk_groups);
 
 	strlcpy(zram->compressor, default_compressor, sizeof(zram->compressor));
 
-- 
2.33.0

Re: [PATCH] zram: use ATTRIBUTE_GROUPS

[Bart Van Assche]

On 10/28/21 1:36 PM, Luis Chamberlain wrote:
> Embrace ATTRIBUTE_GROUPS to avoid boiler plate code.
> This should not introduce any functional changes.
> 
> Signed-off-by: Luis Chamberlain <mcgrof@kernel.org>
> ---
>   drivers/block/zram/zram_drv.c | 11 ++---------
>   1 file changed, 2 insertions(+), 9 deletions(-)
> 
> diff --git a/drivers/block/zram/zram_drv.c b/drivers/block/zram/zram_drv.c
> index fcaf2750f68f..268f727f7cba 100644
> --- a/drivers/block/zram/zram_drv.c
> +++ b/drivers/block/zram/zram_drv.c
> @@ -1874,14 +1874,7 @@ static struct attribute *zram_disk_attrs[] = {
>   	NULL,
>   };
>   
> -static const struct attribute_group zram_disk_attr_group = {
> -	.attrs = zram_disk_attrs,
> -};
> -
> -static const struct attribute_group *zram_disk_attr_groups[] = {
> -	&zram_disk_attr_group,
> -	NULL,
> -};
> +ATTRIBUTE_GROUPS(zram_disk);
>   
>   /*
>    * Allocate and initialize new zram device. the function returns
> @@ -1953,7 +1946,7 @@ static int zram_add(void)
>   		blk_queue_max_write_zeroes_sectors(zram->disk->queue, UINT_MAX);
>   
>   	blk_queue_flag_set(QUEUE_FLAG_STABLE_WRITES, zram->disk->queue);
> -	device_add_disk(NULL, zram->disk, zram_disk_attr_groups);
> +	device_add_disk(NULL, zram->disk, zram_disk_groups);
>   
>   	strlcpy(zram->compressor, default_compressor, sizeof(zram->compressor));
>   
> 

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Re: [PATCH] zram: use ATTRIBUTE_GROUPS

[Luis Chamberlain]

On Thu, Oct 28, 2021 at 01:44:38PM -0700, Bart Van Assche wrote:
> 
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>

Just a gentle reminder.

  Luis

Re: [PATCH] zram: use ATTRIBUTE_GROUPS

[Sergey Senozhatsky]

On (21/10/28 13:36), Luis Chamberlain wrote:
> Embrace ATTRIBUTE_GROUPS to avoid boiler plate code.
> This should not introduce any functional changes.
> 

Cc-ing Andrew  (20211028203600.2157356-1-mcgrof@kernel.org)

Reviewed-by: Sergey Senozhatsky <senozhatsky@chromium.org>