From: Pankaj Raghav <p.raghav@samsung.com>
To: martin@omnibond.com, axboe@kernel.dk, minchan@kernel.org,
akpm@linux-foundation.org, hubcap@omnibond.com,
willy@infradead.org, viro@zeniv.linux.org.uk,
senozhatsky@chromium.org, brauner@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
mcgrof@kernel.org, linux-block@vger.kernel.org,
gost.dev@samsung.com, linux-mm@kvack.org,
devel@lists.orangefs.org, Pankaj Raghav <p.raghav@samsung.com>,
Christoph Hellwig <hch@lst.de>
Subject: [PATCH 3/5] mpage: split bi_end_io callback for reads and writes
Date: Tue, 28 Mar 2023 13:27:14 +0200 [thread overview]
Message-ID: <20230328112716.50120-4-p.raghav@samsung.com> (raw)
In-Reply-To: <20230328112716.50120-1-p.raghav@samsung.com>
Split the bi_end_io handler for reads and writes similar to other aops.
This is a prep patch before we convert end_io handlers to use folios.
Suggested-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
---
fs/mpage.c | 24 +++++++++++++++++++++---
1 file changed, 21 insertions(+), 3 deletions(-)
diff --git a/fs/mpage.c b/fs/mpage.c
index 22b9de5ddd68..3a545bf0f184 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -43,14 +43,28 @@
* status of that page is hard. See end_buffer_async_read() for the details.
* There is no point in duplicating all that complexity.
*/
-static void mpage_end_io(struct bio *bio)
+static void mpage_read_end_io(struct bio *bio)
{
struct bio_vec *bv;
struct bvec_iter_all iter_all;
bio_for_each_segment_all(bv, bio, iter_all) {
struct page *page = bv->bv_page;
- page_endio(page, bio_op(bio),
+ page_endio(page, REQ_OP_READ,
+ blk_status_to_errno(bio->bi_status));
+ }
+
+ bio_put(bio);
+}
+
+static void mpage_write_end_io(struct bio *bio)
+{
+ struct bio_vec *bv;
+ struct bvec_iter_all iter_all;
+
+ bio_for_each_segment_all(bv, bio, iter_all) {
+ struct page *page = bv->bv_page;
+ page_endio(page, REQ_OP_WRITE,
blk_status_to_errno(bio->bi_status));
}
@@ -59,7 +73,11 @@ static void mpage_end_io(struct bio *bio)
static struct bio *mpage_bio_submit(struct bio *bio)
{
- bio->bi_end_io = mpage_end_io;
+ if (op_is_write(bio_op(bio)))
+ bio->bi_end_io = mpage_write_end_io;
+ else
+ bio->bi_end_io = mpage_read_end_io;
+
guard_bio_eod(bio);
submit_bio(bio);
return NULL;
--
2.34.1
next prev parent reply other threads:[~2023-03-28 11:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230328112717eucas1p2eb9395b7e3334c08aa28740b0af46fe9@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 0/5] remove page_endio() Pankaj Raghav
[not found] ` <CGME20230328112718eucas1p214a859cfb3d7b45523356bcc16c373b1@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Pankaj Raghav
2023-03-28 15:19 ` Matthew Wilcox
2023-03-28 16:17 ` Pankaj Raghav
2023-03-29 23:53 ` Christoph Hellwig
2023-03-30 22:51 ` Minchan Kim
2023-03-30 23:16 ` Christoph Hellwig
2023-03-31 1:42 ` Minchan Kim
2023-03-31 11:19 ` Pankaj Raghav
[not found] ` <CGME20230328112718eucas1p263dacecb2a59f5fce510f81685f9d497@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-03-28 15:21 ` Matthew Wilcox
2023-03-28 16:02 ` Pankaj Raghav
2023-03-29 19:10 ` Mike Marshall
[not found] ` <CGME20230328112719eucas1p2b0f94ad7b06990203081d2b125dfc6ac@eucas1p2.samsung.com>
2023-03-28 11:27 ` Pankaj Raghav [this message]
[not found] ` <CGME20230328112720eucas1p1148c03b8664f6c212c7189454a36b796@eucas1p1.samsung.com>
2023-03-28 11:27 ` [PATCH 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
[not found] ` <CGME20230328112720eucas1p2bbb42b49da00b4f2299049bf6bafce48@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 5/5] filemap: remove page_endio() Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230328112716.50120-4-p.raghav@samsung.com \
--to=p.raghav@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).