From: Pankaj Raghav <p.raghav@samsung.com>
To: Matthew Wilcox <willy@infradead.org>, Christoph Hellwig <hch@lst.de>
Cc: <martin@omnibond.com>, <axboe@kernel.dk>, <minchan@kernel.org>,
<akpm@linux-foundation.org>, <hubcap@omnibond.com>,
<viro@zeniv.linux.org.uk>, <senozhatsky@chromium.org>,
<brauner@kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <mcgrof@kernel.org>,
<linux-block@vger.kernel.org>, <gost.dev@samsung.com>,
<linux-mm@kvack.org>, <devel@lists.orangefs.org>
Subject: Re: [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler
Date: Tue, 28 Mar 2023 18:17:11 +0200 [thread overview]
Message-ID: <5865a840-cb5e-ead1-f168-100869081f84@samsung.com> (raw)
In-Reply-To: <ZCMFcTHkTe/1WapL@casper.infradead.org>
On 2023-03-28 17:19, Matthew Wilcox wrote:
> On Tue, Mar 28, 2023 at 01:27:12PM +0200, Pankaj Raghav wrote:
>> -static void zram_page_end_io(struct bio *bio)
>> +static void zram_read_end_io(struct bio *bio)
>> {
>> - struct page *page = bio_first_page_all(bio);
>> -
>> - page_endio(page, op_is_write(bio_op(bio)),
>> - blk_status_to_errno(bio->bi_status));
>> bio_put(bio);
>> }
>>
>> @@ -635,7 +631,7 @@ static int read_from_bdev_async(struct zram *zram, struct bio_vec *bvec,
>> }
>>
>> if (!parent)
>> - bio->bi_end_io = zram_page_end_io;
>> + bio->bi_end_io = zram_read_end_io;
>
> Can we just do:
>
> if (!parent)
> bio->bi_end_io = bio_put;
>
Looks neat. I will wait for Christoph to comment whether just a bio_put() call
is enough in this case for non-chained bios before making this change for the
next version.
Thanks.
next prev parent reply other threads:[~2023-03-28 16:17 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20230328112717eucas1p2eb9395b7e3334c08aa28740b0af46fe9@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 0/5] remove page_endio() Pankaj Raghav
[not found] ` <CGME20230328112718eucas1p214a859cfb3d7b45523356bcc16c373b1@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 1/5] zram: remove the call to page_endio in the bio end_io handler Pankaj Raghav
2023-03-28 15:19 ` Matthew Wilcox
2023-03-28 16:17 ` Pankaj Raghav [this message]
2023-03-29 23:53 ` Christoph Hellwig
2023-03-30 22:51 ` Minchan Kim
2023-03-30 23:16 ` Christoph Hellwig
2023-03-31 1:42 ` Minchan Kim
2023-03-31 11:19 ` Pankaj Raghav
[not found] ` <CGME20230328112718eucas1p263dacecb2a59f5fce510f81685f9d497@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 2/5] orangefs: use folios in orangefs_readahead Pankaj Raghav
2023-03-28 15:21 ` Matthew Wilcox
2023-03-28 16:02 ` Pankaj Raghav
2023-03-29 19:10 ` Mike Marshall
[not found] ` <CGME20230328112719eucas1p2b0f94ad7b06990203081d2b125dfc6ac@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 3/5] mpage: split bi_end_io callback for reads and writes Pankaj Raghav
[not found] ` <CGME20230328112720eucas1p1148c03b8664f6c212c7189454a36b796@eucas1p1.samsung.com>
2023-03-28 11:27 ` [PATCH 4/5] mpage: use folios in bio end_io handler Pankaj Raghav
[not found] ` <CGME20230328112720eucas1p2bbb42b49da00b4f2299049bf6bafce48@eucas1p2.samsung.com>
2023-03-28 11:27 ` [PATCH 5/5] filemap: remove page_endio() Pankaj Raghav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5865a840-cb5e-ead1-f168-100869081f84@samsung.com \
--to=p.raghav@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=brauner@kernel.org \
--cc=devel@lists.orangefs.org \
--cc=gost.dev@samsung.com \
--cc=hch@lst.de \
--cc=hubcap@omnibond.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=martin@omnibond.com \
--cc=mcgrof@kernel.org \
--cc=minchan@kernel.org \
--cc=senozhatsky@chromium.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).