linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] block: mq: Add some minor doc for core structs
@ 2018-04-20  8:29 Linus Walleij
  2018-04-20 15:19 ` Jens Axboe
  0 siblings, 1 reply; 2+ messages in thread
From: Linus Walleij @ 2018-04-20  8:29 UTC (permalink / raw)
  To: linux-block, Jens Axboe; +Cc: Linus Walleij

As it came up in discussion on the mailing list that the semantic
meaning of 'blk_mq_ctx' and 'blk_mq_hw_ctx' isn't completely
obvious to everyone, let's add some minimal kerneldoc for a
starter.

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>
---
 block/blk-mq.h         | 3 +++
 include/linux/blk-mq.h | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/block/blk-mq.h b/block/blk-mq.h
index 88c558f71819..89b5cd3a6c70 100644
--- a/block/blk-mq.h
+++ b/block/blk-mq.h
@@ -7,6 +7,9 @@
 
 struct blk_mq_tag_set;
 
+/**
+ * struct blk_mq_ctx - State for a software queue facing the submitting CPUs
+ */
 struct blk_mq_ctx {
 	struct {
 		spinlock_t		lock;
diff --git a/include/linux/blk-mq.h b/include/linux/blk-mq.h
index e3986f4b3461..ebc34a5686dc 100644
--- a/include/linux/blk-mq.h
+++ b/include/linux/blk-mq.h
@@ -9,6 +9,9 @@
 struct blk_mq_tags;
 struct blk_flush_queue;
 
+/**
+ * struct blk_mq_hw_ctx - State for a hardware queue facing the hardware block device
+ */
 struct blk_mq_hw_ctx {
 	struct {
 		spinlock_t		lock;
-- 
2.14.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] block: mq: Add some minor doc for core structs
  2018-04-20  8:29 [PATCH] block: mq: Add some minor doc for core structs Linus Walleij
@ 2018-04-20 15:19 ` Jens Axboe
  0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2018-04-20 15:19 UTC (permalink / raw)
  To: Linus Walleij, linux-block

On 4/20/18 2:29 AM, Linus Walleij wrote:
> As it came up in discussion on the mailing list that the semantic
> meaning of 'blk_mq_ctx' and 'blk_mq_hw_ctx' isn't completely
> obvious to everyone, let's add some minimal kerneldoc for a
> starter.

Thanks Linus, applied.

-- 
Jens Axboe

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-20 15:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-20  8:29 [PATCH] block: mq: Add some minor doc for core structs Linus Walleij
2018-04-20 15:19 ` Jens Axboe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).