Linux-Block Archive on lore.kernel.org
 help / color / Atom feed
From: Bart Van Assche <bvanassche@acm.org>
To: Hou Tao <houtao1@huawei.com>, linux-block@vger.kernel.org
Cc: Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
Date: Mon, 27 Apr 2020 10:27:54 -0700
Message-ID: <244626f4-3469-1127-377c-d54c589d829b@acm.org> (raw)
In-Reply-To: <20200427131250.13725-1-houtao1@huawei.com>

On 2020-04-27 06:12, Hou Tao wrote:
> And use rq directly.
> 
> Signed-off-by: Hou Tao <houtao1@huawei.com>
> ---
>  block/blk-mq-debugfs.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
> index b3f2ba483992..7a79db81a63f 100644
> --- a/block/blk-mq-debugfs.c
> +++ b/block/blk-mq-debugfs.c
> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>  	const struct show_busy_params *params = data;
>  
>  	if (rq->mq_hctx == params->hctx)
> -		__blk_mq_debugfs_rq_show(params->m,
> -					 list_entry_rq(&rq->queuelist));
> +		__blk_mq_debugfs_rq_show(params->m, rq);
>  
>  	return true;
>  }

Reviewed-by: Bart Van Assche <bvanassche@acm.org>

  reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-27 13:12 Hou Tao
2020-04-27 17:27 ` Bart Van Assche [this message]
2020-05-25  6:32   ` Hou Tao
2020-07-01  1:24     ` Hou Tao
2020-07-01  4:00 ` Ming Lei
2020-07-01 13:26 ` Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=244626f4-3469-1127-377c-d54c589d829b@acm.org \
    --to=bvanassche@acm.org \
    --cc=axboe@kernel.dk \
    --cc=houtao1@huawei.com \
    --cc=linux-block@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org
	public-inbox-index linux-block

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git