From: Hou Tao <houtao1@huawei.com>
To: <linux-block@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Cc: Bart Van Assche <bvanassche@acm.org>
Subject: Re: [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq()
Date: Mon, 25 May 2020 14:32:19 +0800 [thread overview]
Message-ID: <51b569f8-57a0-58bb-4f41-ab1f10363918@huawei.com> (raw)
In-Reply-To: <244626f4-3469-1127-377c-d54c589d829b@acm.org>
ping ?
On 2020/4/28 1:27, Bart Van Assche wrote:
> On 2020-04-27 06:12, Hou Tao wrote:
>> And use rq directly.
>>
>> Signed-off-by: Hou Tao <houtao1@huawei.com>
>> ---
>> block/blk-mq-debugfs.c | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c
>> index b3f2ba483992..7a79db81a63f 100644
>> --- a/block/blk-mq-debugfs.c
>> +++ b/block/blk-mq-debugfs.c
>> @@ -400,8 +400,7 @@ static bool hctx_show_busy_rq(struct request *rq, void *data, bool reserved)
>> const struct show_busy_params *params = data;
>>
>> if (rq->mq_hctx == params->hctx)
>> - __blk_mq_debugfs_rq_show(params->m,
>> - list_entry_rq(&rq->queuelist));
>> + __blk_mq_debugfs_rq_show(params->m, rq);
>>
>> return true;
>> }
>
> Reviewed-by: Bart Van Assche <bvanassche@acm.org>
>
>
next prev parent reply other threads:[~2020-05-25 6:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 13:12 [PATCH 1/1] blk-mq: remove the pointless call of list_entry_rq() in hctx_show_busy_rq() Hou Tao
2020-04-27 17:27 ` Bart Van Assche
2020-05-25 6:32 ` Hou Tao [this message]
2020-07-01 1:24 ` Hou Tao
2020-07-01 4:00 ` Ming Lei
2020-07-01 13:26 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=51b569f8-57a0-58bb-4f41-ab1f10363918@huawei.com \
--to=houtao1@huawei.com \
--cc=axboe@kernel.dk \
--cc=bvanassche@acm.org \
--cc=linux-block@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).