* [PATCH] block/swim: Return -EROFS for FMODE_WRITE
@ 2019-02-14 22:13 Finn Thain
0 siblings, 0 replies; only message in thread
From: Finn Thain @ 2019-02-14 22:13 UTC (permalink / raw)
To: Jens Axboe; +Cc: linux-m68k, linux-block, linux-kernel
Write requests are not supported by the driver and result in IO errors:
print_req_error: I/O error, dev fd0, sector 0
buffer_io_error: 26 callbacks suppressed
Buffer I/O error on dev fd0, logical block 0, lost async page write
Buffer I/O error on dev fd0, logical block 1, lost async page write
Buffer I/O error on dev fd0, logical block 2, lost async page write
Buffer I/O error on dev fd0, logical block 3, lost async page write
Buffer I/O error on dev fd0, logical block 4, lost async page write
Buffer I/O error on dev fd0, logical block 5, lost async page write
Buffer I/O error on dev fd0, logical block 6, lost async page write
Buffer I/O error on dev fd0, logical block 7, lost async page write
Buffer I/O error on dev fd0, logical block 8, lost async page write
Buffer I/O error on dev fd0, logical block 9, lost async page write
print_req_error: I/O error, dev fd0, sector 2688
print_req_error: I/O error, dev fd0, sector 0
Cc: linux-m68k@lists.linux-m68k.org
Tested-by: Stan Johnson <userm57@yahoo.com>
Signed-off-by: Finn Thain <fthain@telegraphics.com.au>
---
drivers/block/swim.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/block/swim.c b/drivers/block/swim.c
index 3fa6fcc34790..dd19f422fb0d 100644
--- a/drivers/block/swim.c
+++ b/drivers/block/swim.c
@@ -643,7 +643,7 @@ static int floppy_open(struct block_device *bdev, fmode_t mode)
if (mode & (FMODE_READ|FMODE_WRITE)) {
check_disk_change(bdev);
- if ((mode & FMODE_WRITE) && fs->write_protected) {
+ if (mode & FMODE_WRITE) { /* not implemented */
err = -EROFS;
goto out;
}
--
2.19.2
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2019-02-14 22:25 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-14 22:13 [PATCH] block/swim: Return -EROFS for FMODE_WRITE Finn Thain
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).