* [PATCH] blk-mq: Remove unnecessary local variable
@ 2020-07-04 7:26 Baolin Wang
2020-07-10 8:22 ` Baolin Wang
2020-07-10 13:59 ` Jens Axboe
0 siblings, 2 replies; 4+ messages in thread
From: Baolin Wang @ 2020-07-04 7:26 UTC (permalink / raw)
To: axboe; +Cc: ming.lei, baolin.wang, baolin.wang7, linux-block, linux-kernel
Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
---
block/blk-mq-sched.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
index 1c52e56a19b1..b8db72cf1043 100644
--- a/block/blk-mq-sched.c
+++ b/block/blk-mq-sched.c
@@ -96,7 +96,6 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
struct request *rq;
LIST_HEAD(hctx_list);
unsigned int count = 0;
- bool ret;
list_for_each_entry(rq, rq_list, queuelist) {
if (rq->mq_hctx != hctx) {
@@ -108,8 +107,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
list_splice_tail_init(rq_list, &hctx_list);
dispatch:
- ret = blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
- return ret;
+ return blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
}
#define BLK_MQ_BUDGET_DELAY 3 /* ms units */
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] blk-mq: Remove unnecessary local variable
2020-07-04 7:26 [PATCH] blk-mq: Remove unnecessary local variable Baolin Wang
@ 2020-07-10 8:22 ` Baolin Wang
2020-07-10 9:45 ` Ming Lei
2020-07-10 13:59 ` Jens Axboe
1 sibling, 1 reply; 4+ messages in thread
From: Baolin Wang @ 2020-07-10 8:22 UTC (permalink / raw)
To: axboe; +Cc: ming.lei, baolin.wang7, linux-block, linux-kernel
Hi,
On Sat, Jul 04, 2020 at 03:26:14PM +0800, Baolin Wang wrote:
> Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
>
A gentle ping?
> Signed-off-by: Baolin Wang <baolin.wang@linux.alibaba.com>
> ---
> block/blk-mq-sched.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/block/blk-mq-sched.c b/block/blk-mq-sched.c
> index 1c52e56a19b1..b8db72cf1043 100644
> --- a/block/blk-mq-sched.c
> +++ b/block/blk-mq-sched.c
> @@ -96,7 +96,6 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
> struct request *rq;
> LIST_HEAD(hctx_list);
> unsigned int count = 0;
> - bool ret;
>
> list_for_each_entry(rq, rq_list, queuelist) {
> if (rq->mq_hctx != hctx) {
> @@ -108,8 +107,7 @@ static bool blk_mq_dispatch_hctx_list(struct list_head *rq_list)
> list_splice_tail_init(rq_list, &hctx_list);
>
> dispatch:
> - ret = blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
> - return ret;
> + return blk_mq_dispatch_rq_list(hctx, &hctx_list, count);
> }
>
> #define BLK_MQ_BUDGET_DELAY 3 /* ms units */
> --
> 2.17.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] blk-mq: Remove unnecessary local variable
2020-07-10 8:22 ` Baolin Wang
@ 2020-07-10 9:45 ` Ming Lei
0 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2020-07-10 9:45 UTC (permalink / raw)
To: Baolin Wang; +Cc: axboe, baolin.wang7, linux-block, linux-kernel
On Fri, Jul 10, 2020 at 04:22:10PM +0800, Baolin Wang wrote:
> Hi,
>
> On Sat, Jul 04, 2020 at 03:26:14PM +0800, Baolin Wang wrote:
> > Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
> >
>
> A gentle ping?
Reviewed-by: Ming Lei <ming.lei@redhat.com>
--
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] blk-mq: Remove unnecessary local variable
2020-07-04 7:26 [PATCH] blk-mq: Remove unnecessary local variable Baolin Wang
2020-07-10 8:22 ` Baolin Wang
@ 2020-07-10 13:59 ` Jens Axboe
1 sibling, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2020-07-10 13:59 UTC (permalink / raw)
To: Baolin Wang; +Cc: ming.lei, baolin.wang7, linux-block, linux-kernel
On 7/4/20 1:26 AM, Baolin Wang wrote:
> Remove unnecessary local variable 'ret' in blk_mq_dispatch_hctx_list().
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-07-10 13:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-04 7:26 [PATCH] blk-mq: Remove unnecessary local variable Baolin Wang
2020-07-10 8:22 ` Baolin Wang
2020-07-10 9:45 ` Ming Lei
2020-07-10 13:59 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).