* [PATCH 0/1] s390/dasd: Kconfig patch
@ 2020-04-06 7:41 Stefan Haberland
2020-04-06 7:41 ` [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE Stefan Haberland
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Haberland @ 2020-04-06 7:41 UTC (permalink / raw)
To: axboe; +Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
Hi Jens,
please see the following patch that fixes the DASD iosched Kconfig.
Regards,
Stefan
Krzysztof Kozlowski (1):
s390: Cleanup removed IOSCHED_DEADLINE
drivers/s390/block/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.17.1
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
2020-04-06 7:41 [PATCH 0/1] s390/dasd: Kconfig patch Stefan Haberland
@ 2020-04-06 7:41 ` Stefan Haberland
2020-04-06 15:32 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Haberland @ 2020-04-06 7:41 UTC (permalink / raw)
To: axboe; +Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
From: Krzysztof Kozlowski <krzk@kernel.org>
CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
remove legacy IO schedulers").
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Stefan Haberland <sth@linux.ibm.com>
---
drivers/s390/block/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s390/block/Kconfig b/drivers/s390/block/Kconfig
index a8682f69effc..1f06b19cb290 100644
--- a/drivers/s390/block/Kconfig
+++ b/drivers/s390/block/Kconfig
@@ -26,7 +26,7 @@ config DASD
def_tristate y
prompt "Support for DASD devices"
depends on CCW && BLOCK
- select IOSCHED_DEADLINE
+ select MQ_IOSCHED_DEADLINE
help
Enable this option if you want to access DASDs directly utilizing
S/390s channel subsystem commands. This is necessary for running
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
2020-04-06 7:41 ` [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE Stefan Haberland
@ 2020-04-06 15:32 ` Jens Axboe
2020-04-07 10:01 ` Stefan Haberland
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2020-04-06 15:32 UTC (permalink / raw)
To: Stefan Haberland
Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
On 4/6/20 1:41 AM, Stefan Haberland wrote:
> From: Krzysztof Kozlowski <krzk@kernel.org>
>
> CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
> remove legacy IO schedulers").
Isn't this a leftover thing from when dasd selected deadline
internally? I don't think we need this anymore, just kill the
select completely.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
2020-04-06 15:32 ` Jens Axboe
@ 2020-04-07 10:01 ` Stefan Haberland
2020-04-07 19:24 ` Jens Axboe
0 siblings, 1 reply; 6+ messages in thread
From: Stefan Haberland @ 2020-04-07 10:01 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
Am 06.04.20 um 17:32 schrieb Jens Axboe:
> On 4/6/20 1:41 AM, Stefan Haberland wrote:
>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>
>> CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
>> remove legacy IO schedulers").
> Isn't this a leftover thing from when dasd selected deadline
> internally? I don't think we need this anymore, just kill the
> select completely.
>
Basically yes.
We still have the recommendation to use deadline and there are some udev
rules in place which select it.
So I thought it might be a good idea to keep the line. But I am also
fine to drop it completely if you prefer this.
Regards,
Stefan
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
2020-04-07 10:01 ` Stefan Haberland
@ 2020-04-07 19:24 ` Jens Axboe
2020-04-15 9:18 ` Stefan Haberland
0 siblings, 1 reply; 6+ messages in thread
From: Jens Axboe @ 2020-04-07 19:24 UTC (permalink / raw)
To: Stefan Haberland
Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
On 4/7/20 3:01 AM, Stefan Haberland wrote:
> Am 06.04.20 um 17:32 schrieb Jens Axboe:
>> On 4/6/20 1:41 AM, Stefan Haberland wrote:
>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>
>>> CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
>>> remove legacy IO schedulers").
>> Isn't this a leftover thing from when dasd selected deadline
>> internally? I don't think we need this anymore, just kill the
>> select completely.
>>
>
> Basically yes.
> We still have the recommendation to use deadline and there are some udev
> rules in place which select it.
> So I thought it might be a good idea to keep the line. But I am also
> fine to drop it completely if you prefer this.
I don't feel super strongly about it, but at the same time I don't
think there's a reason for it. Besides, I think everyone has deadline
enabled. So I guess we should just kill it.
--
Jens Axboe
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE
2020-04-07 19:24 ` Jens Axboe
@ 2020-04-15 9:18 ` Stefan Haberland
0 siblings, 0 replies; 6+ messages in thread
From: Stefan Haberland @ 2020-04-15 9:18 UTC (permalink / raw)
To: Jens Axboe
Cc: linux-block, hoeppner, linux-s390, heiko.carstens, gor, borntraeger
Am 07.04.20 um 21:24 schrieb Jens Axboe:
> On 4/7/20 3:01 AM, Stefan Haberland wrote:
>> Am 06.04.20 um 17:32 schrieb Jens Axboe:
>>> On 4/6/20 1:41 AM, Stefan Haberland wrote:
>>>> From: Krzysztof Kozlowski <krzk@kernel.org>
>>>>
>>>> CONFIG_IOSCHED_DEADLINE is gone since commit f382fb0bcef4 ("block:
>>>> remove legacy IO schedulers").
>>> Isn't this a leftover thing from when dasd selected deadline
>>> internally? I don't think we need this anymore, just kill the
>>> select completely.
>>>
>> Basically yes.
>> We still have the recommendation to use deadline and there are some udev
>> rules in place which select it.
>> So I thought it might be a good idea to keep the line. But I am also
>> fine to drop it completely if you prefer this.
> I don't feel super strongly about it, but at the same time I don't
> think there's a reason for it. Besides, I think everyone has deadline
> enabled. So I guess we should just kill it.
>
OK, thanks for your opinion. I will remove the line and come up with a
different patch.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-04-15 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-06 7:41 [PATCH 0/1] s390/dasd: Kconfig patch Stefan Haberland
2020-04-06 7:41 ` [PATCH 1/1] s390: Cleanup removed IOSCHED_DEADLINE Stefan Haberland
2020-04-06 15:32 ` Jens Axboe
2020-04-07 10:01 ` Stefan Haberland
2020-04-07 19:24 ` Jens Axboe
2020-04-15 9:18 ` Stefan Haberland
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).