From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>
Cc: shawn.lin@rock-chips.com,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Avri Altman <avri.altman@wdc.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands
Date: Fri, 7 May 2021 09:44:30 +0800 [thread overview]
Message-ID: <6d528e02-dd27-65d3-0cd3-e764cc780a81@rock-chips.com> (raw)
In-Reply-To: <20210504161222.101536-3-ulf.hansson@linaro.org>
On 2021/5/5 0:12, Ulf Hansson wrote:
> In mmc_send_hpi_cmd() the host->max_busy_timeout is being validated towards
> the timeout for the eMMC HPI command, as to decide whether an R1 or R1B
> response should be used.
>
> Although, it has turned out the some host can't cope with that conversion,
> but needs R1B, which means MMC_CAP_NEED_RSP_BUSY is set for them. Let's
> take this into account, via using the common mmc_prepare_busy_cmd() when
> doing the validation, which also avoids some open coding.
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/core/mmc_ops.c | 21 +++++----------------
> 1 file changed, 5 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index 025a4134d5c7..66ae699a410f 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -817,28 +817,17 @@ static int mmc_send_hpi_cmd(struct mmc_card *card)
> {
> unsigned int busy_timeout_ms = card->ext_csd.out_of_int_time;
> struct mmc_host *host = card->host;
> - bool use_r1b_resp = true;
> + bool use_r1b_resp = false;
> struct mmc_command cmd = {};
> int err;
>
> cmd.opcode = card->ext_csd.hpi_cmd;
> cmd.arg = card->rca << 16 | 1;
> + cmd.flags = MMC_RSP_R1 | MMC_CMD_AC;
>
> - /*
> - * Make sure the host's max_busy_timeout fit the needed timeout for HPI.
> - * In case it doesn't, let's instruct the host to avoid HW busy
> - * detection, by using a R1 response instead of R1B.
> - */
> - if (host->max_busy_timeout && busy_timeout_ms > host->max_busy_timeout)
> - use_r1b_resp = false;
> -
> - if (cmd.opcode == MMC_STOP_TRANSMISSION && use_r1b_resp) {
> - cmd.flags = MMC_RSP_R1B | MMC_CMD_AC;
> - cmd.busy_timeout = busy_timeout_ms;
> - } else {
> - cmd.flags = MMC_RSP_R1 | MMC_CMD_AC;
> - use_r1b_resp = false;
> - }
> + if (cmd.opcode == MMC_STOP_TRANSMISSION)
> + use_r1b_resp = mmc_prepare_busy_cmd(host, &cmd,
> + busy_timeout_ms);
>
> err = mmc_wait_for_cmd(host, &cmd, 0);
> if (err) {
>
next prev parent reply other threads:[~2021-05-07 1:48 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 16:12 [PATCH 00/11] Initital support for new power/perf features for SD cards Ulf Hansson
2021-05-04 16:12 ` [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling Ulf Hansson
2021-05-06 12:50 ` Linus Walleij
2021-05-07 1:42 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands Ulf Hansson
2021-05-06 12:51 ` Linus Walleij
2021-05-07 1:44 ` Shawn Lin [this message]
2021-05-04 16:12 ` [PATCH 03/11] mmc: core: Re-structure some code in __mmc_poll_for_busy() Ulf Hansson
2021-05-06 12:52 ` Linus Walleij
2021-05-07 1:48 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() Ulf Hansson
2021-05-06 12:53 ` Linus Walleij
2021-05-07 1:51 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 05/11] mmc: core: Enable eMMC sleep commands to use HW busy polling Ulf Hansson
2021-05-06 12:55 ` Linus Walleij
2021-05-07 1:52 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds Ulf Hansson
2021-05-06 12:56 ` Linus Walleij
2021-05-06 13:00 ` Linus Walleij
2021-05-07 7:30 ` Ulf Hansson
2021-05-07 1:53 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() Ulf Hansson
2021-05-06 12:57 ` Linus Walleij
2021-05-07 1:54 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 08/11] mmc: core: Parse the SD SCR register for support of CMD48/49 and CMD58/59 Ulf Hansson
2021-05-06 13:01 ` Linus Walleij
2021-05-07 1:58 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 09/11] mmc: core: Read the SD function extension registers for power management Ulf Hansson
2021-05-06 13:04 ` Linus Walleij
2021-05-07 2:06 ` Shawn Lin
2021-05-07 7:27 ` Ulf Hansson
2021-05-07 7:48 ` Shawn Lin
2021-05-07 11:36 ` Ulf Hansson
2021-05-04 16:12 ` [PATCH 10/11] mmc: core: Read performance enhancements registers for SD cards Ulf Hansson
2021-05-06 13:05 ` Linus Walleij
2021-05-04 16:12 ` [PATCH 11/11] mmc: core: Add support for Power Off Notification " Ulf Hansson
2021-05-06 13:07 ` Linus Walleij
2021-05-07 6:44 ` [PATCH 00/11] Initital support for new power/perf features " Avri Altman
2021-05-07 7:31 ` Ulf Hansson
2021-05-11 10:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d528e02-dd27-65d3-0cd3-e764cc780a81@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).