From: Shawn Lin <shawn.lin@rock-chips.com>
To: Ulf Hansson <ulf.hansson@linaro.org>,
linux-mmc@vger.kernel.org,
Adrian Hunter <adrian.hunter@intel.com>
Cc: shawn.lin@rock-chips.com,
Linus Walleij <linus.walleij@linaro.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
Avri Altman <avri.altman@wdc.com>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
linux-block@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy()
Date: Fri, 7 May 2021 09:51:13 +0800 [thread overview]
Message-ID: <fd7bf481-dfc2-4124-cbc3-4d55ec3b803b@rock-chips.com> (raw)
In-Reply-To: <20210504161222.101536-5-ulf.hansson@linaro.org>
On 2021/5/5 0:12, Ulf Hansson wrote:
> Via __mmc_poll_for_busy() we end up polling with the ->card_busy() host ops
> or by sending the CMD13. To allow polling of different types, which is
> needed to support a few new SD card features, let's rework the code around
> __mmc_poll_for_busy() to make it more generic.
>
> More precisely, let __mmc_poll_for_busy() take a pointer to a callback
> function as in-parameter, which it calls to poll for busy state completion.
> Additionally, let's share __mmc_poll_for_busy() to allow it to be re-used
> outside of mmc_ops.c. Subsequent changes will make use of it.
>
Reviewed-by: Shawn Lin <shawn.lin@rock-chips.com>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
> ---
> drivers/mmc/core/core.c | 2 +-
> drivers/mmc/core/mmc_ops.c | 42 ++++++++++++++++++++++++--------------
> drivers/mmc/core/mmc_ops.h | 5 ++++-
> 3 files changed, 32 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> index b00c84ea8441..b039dcff17f8 100644
> --- a/drivers/mmc/core/core.c
> +++ b/drivers/mmc/core/core.c
> @@ -1671,7 +1671,7 @@ static int mmc_do_erase(struct mmc_card *card, unsigned int from,
> goto out;
>
> /* Let's poll to find out when the erase operation completes. */
> - err = mmc_poll_for_busy(card, busy_timeout, MMC_BUSY_ERASE);
> + err = mmc_poll_for_busy(card, busy_timeout, false, MMC_BUSY_ERASE);
>
> out:
> mmc_retune_release(card->host);
> diff --git a/drivers/mmc/core/mmc_ops.c b/drivers/mmc/core/mmc_ops.c
> index ccaee1cb7ff5..653627fe02a3 100644
> --- a/drivers/mmc/core/mmc_ops.c
> +++ b/drivers/mmc/core/mmc_ops.c
> @@ -53,6 +53,12 @@ static const u8 tuning_blk_pattern_8bit[] = {
> 0xff, 0x77, 0x77, 0xff, 0x77, 0xbb, 0xdd, 0xee,
> };
>
> +struct mmc_busy_data {
> + struct mmc_card *card;
> + bool retry_crc_err;
> + enum mmc_busy_cmd busy_cmd;
> +};
> +
> int __mmc_send_status(struct mmc_card *card, u32 *status, unsigned int retries)
> {
> int err;
> @@ -424,10 +430,10 @@ int mmc_switch_status(struct mmc_card *card, bool crc_err_fatal)
> return mmc_switch_status_error(card->host, status);
> }
>
> -static int mmc_busy_status(struct mmc_card *card, bool retry_crc_err,
> - enum mmc_busy_cmd busy_cmd, bool *busy)
> +static int mmc_busy_cb(void *cb_data, bool *busy)
> {
> - struct mmc_host *host = card->host;
> + struct mmc_busy_data *data = cb_data;
> + struct mmc_host *host = data->card->host;
> u32 status = 0;
> int err;
>
> @@ -436,17 +442,17 @@ static int mmc_busy_status(struct mmc_card *card, bool retry_crc_err,
> return 0;
> }
>
> - err = mmc_send_status(card, &status);
> - if (retry_crc_err && err == -EILSEQ) {
> + err = mmc_send_status(data->card, &status);
> + if (data->retry_crc_err && err == -EILSEQ) {
> *busy = true;
> return 0;
> }
> if (err)
> return err;
>
> - switch (busy_cmd) {
> + switch (data->busy_cmd) {
> case MMC_BUSY_CMD6:
> - err = mmc_switch_status_error(card->host, status);
> + err = mmc_switch_status_error(host, status);
> break;
> case MMC_BUSY_ERASE:
> err = R1_STATUS(status) ? -EIO : 0;
> @@ -464,8 +470,9 @@ static int mmc_busy_status(struct mmc_card *card, bool retry_crc_err,
> return 0;
> }
>
> -static int __mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> - bool retry_crc_err, enum mmc_busy_cmd busy_cmd)
> +int __mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> + int (*busy_cb)(void *cb_data, bool *busy),
> + void *cb_data)
> {
> struct mmc_host *host = card->host;
> int err;
> @@ -482,7 +489,7 @@ static int __mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> */
> expired = time_after(jiffies, timeout);
>
> - err = mmc_busy_status(card, retry_crc_err, busy_cmd, &busy);
> + err = (*busy_cb)(cb_data, &busy);
> if (err)
> return err;
>
> @@ -505,9 +512,15 @@ static int __mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> }
>
> int mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> - enum mmc_busy_cmd busy_cmd)
> + bool retry_crc_err, enum mmc_busy_cmd busy_cmd)
> {
> - return __mmc_poll_for_busy(card, timeout_ms, false, busy_cmd);
> + struct mmc_busy_data cb_data;
> +
> + cb_data.card = card;
> + cb_data.retry_crc_err = retry_crc_err;
> + cb_data.busy_cmd = busy_cmd;
> +
> + return __mmc_poll_for_busy(card, timeout_ms, &mmc_busy_cb, &cb_data);
> }
>
> bool mmc_prepare_busy_cmd(struct mmc_host *host, struct mmc_command *cmd,
> @@ -591,8 +604,7 @@ int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> }
>
> /* Let's try to poll to find out when the command is completed. */
> - err = __mmc_poll_for_busy(card, timeout_ms, retry_crc_err,
> - MMC_BUSY_CMD6);
> + err = mmc_poll_for_busy(card, timeout_ms, retry_crc_err, MMC_BUSY_CMD6);
> if (err)
> goto out;
>
> @@ -840,7 +852,7 @@ static int mmc_send_hpi_cmd(struct mmc_card *card)
> return 0;
>
> /* Let's poll to find out when the HPI request completes. */
> - return mmc_poll_for_busy(card, busy_timeout_ms, MMC_BUSY_HPI);
> + return mmc_poll_for_busy(card, busy_timeout_ms, false, MMC_BUSY_HPI);
> }
>
> /**
> diff --git a/drivers/mmc/core/mmc_ops.h b/drivers/mmc/core/mmc_ops.h
> index ba898c435658..aca66c128804 100644
> --- a/drivers/mmc/core/mmc_ops.h
> +++ b/drivers/mmc/core/mmc_ops.h
> @@ -38,8 +38,11 @@ int mmc_get_ext_csd(struct mmc_card *card, u8 **new_ext_csd);
> int mmc_switch_status(struct mmc_card *card, bool crc_err_fatal);
> bool mmc_prepare_busy_cmd(struct mmc_host *host, struct mmc_command *cmd,
> unsigned int timeout_ms);
> +int __mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> + int (*busy_cb)(void *cb_data, bool *busy),
> + void *cb_data);
> int mmc_poll_for_busy(struct mmc_card *card, unsigned int timeout_ms,
> - enum mmc_busy_cmd busy_cmd);
> + bool retry_crc_err, enum mmc_busy_cmd busy_cmd);
> int __mmc_switch(struct mmc_card *card, u8 set, u8 index, u8 value,
> unsigned int timeout_ms, unsigned char timing,
> bool send_status, bool retry_crc_err, unsigned int retries);
>
next prev parent reply other threads:[~2021-05-07 1:51 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-04 16:12 [PATCH 00/11] Initital support for new power/perf features for SD cards Ulf Hansson
2021-05-04 16:12 ` [PATCH 01/11] mmc: core: Drop open coding when preparing commands with busy signaling Ulf Hansson
2021-05-06 12:50 ` Linus Walleij
2021-05-07 1:42 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 02/11] mmc: core: Take into account MMC_CAP_NEED_RSP_BUSY for eMMC HPI commands Ulf Hansson
2021-05-06 12:51 ` Linus Walleij
2021-05-07 1:44 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 03/11] mmc: core: Re-structure some code in __mmc_poll_for_busy() Ulf Hansson
2021-05-06 12:52 ` Linus Walleij
2021-05-07 1:48 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 04/11] mmc: core: Extend re-use of __mmc_poll_for_busy() Ulf Hansson
2021-05-06 12:53 ` Linus Walleij
2021-05-07 1:51 ` Shawn Lin [this message]
2021-05-04 16:12 ` [PATCH 05/11] mmc: core: Enable eMMC sleep commands to use HW busy polling Ulf Hansson
2021-05-06 12:55 ` Linus Walleij
2021-05-07 1:52 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 06/11] mmc: core: Prepare mmc_send_cxd_data() to be re-used for additional cmds Ulf Hansson
2021-05-06 12:56 ` Linus Walleij
2021-05-06 13:00 ` Linus Walleij
2021-05-07 7:30 ` Ulf Hansson
2021-05-07 1:53 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 07/11] mmc: core: Drop open coding in mmc_sd_switch() Ulf Hansson
2021-05-06 12:57 ` Linus Walleij
2021-05-07 1:54 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 08/11] mmc: core: Parse the SD SCR register for support of CMD48/49 and CMD58/59 Ulf Hansson
2021-05-06 13:01 ` Linus Walleij
2021-05-07 1:58 ` Shawn Lin
2021-05-04 16:12 ` [PATCH 09/11] mmc: core: Read the SD function extension registers for power management Ulf Hansson
2021-05-06 13:04 ` Linus Walleij
2021-05-07 2:06 ` Shawn Lin
2021-05-07 7:27 ` Ulf Hansson
2021-05-07 7:48 ` Shawn Lin
2021-05-07 11:36 ` Ulf Hansson
2021-05-04 16:12 ` [PATCH 10/11] mmc: core: Read performance enhancements registers for SD cards Ulf Hansson
2021-05-06 13:05 ` Linus Walleij
2021-05-04 16:12 ` [PATCH 11/11] mmc: core: Add support for Power Off Notification " Ulf Hansson
2021-05-06 13:07 ` Linus Walleij
2021-05-07 6:44 ` [PATCH 00/11] Initital support for new power/perf features " Avri Altman
2021-05-07 7:31 ` Ulf Hansson
2021-05-11 10:56 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fd7bf481-dfc2-4124-cbc3-4d55ec3b803b@rock-chips.com \
--to=shawn.lin@rock-chips.com \
--cc=adrian.hunter@intel.com \
--cc=avri.altman@wdc.com \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=ulf.hansson@linaro.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).