* [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static
@ 2020-09-07 14:06 Wang Hai
2020-09-07 19:41 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Wang Hai @ 2020-09-07 14:06 UTC (permalink / raw)
To: axboe, rostedt, mingo; +Cc: linux-kernel, linux-block
The sparse tool complains as follows:
kernel/trace/blktrace.c:796:5: warning:
symbol 'blk_trace_bio_get_cgid' was not declared. Should it be static?
This function is not used outside of blktrace.c, so this commit
marks it static.
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wang Hai <wanghai38@huawei.com>
---
kernel/trace/blktrace.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c
index 4b3a42fc3b24..c0887f32f647 100644
--- a/kernel/trace/blktrace.c
+++ b/kernel/trace/blktrace.c
@@ -793,7 +793,7 @@ static u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
return cgroup_id(bio_blkcg(bio)->css.cgroup);
}
#else
-u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
+static u64 blk_trace_bio_get_cgid(struct request_queue *q, struct bio *bio)
{
return 0;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static
2020-09-07 14:06 [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static Wang Hai
@ 2020-09-07 19:41 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-09-07 19:41 UTC (permalink / raw)
To: Wang Hai, rostedt, mingo; +Cc: linux-kernel, linux-block
On 9/7/20 8:06 AM, Wang Hai wrote:
> The sparse tool complains as follows:
>
> kernel/trace/blktrace.c:796:5: warning:
> symbol 'blk_trace_bio_get_cgid' was not declared. Should it be static?
>
> This function is not used outside of blktrace.c, so this commit
> marks it static.
Applied, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-09-07 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-07 14:06 [PATCH -next] blktrace: make function blk_trace_bio_get_cgid() static Wang Hai
2020-09-07 19:41 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).