From: Artur Paszkiewicz <artur.paszkiewicz@intel.com>
To: Guoqing Jiang <jgq516@gmail.com>, Christoph Hellwig <hch@infradead.org>
Cc: song@kernel.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org, pawel.wiejacha@rtbhouse.com
Subject: Re: [PATCH] md: don't account io stat for split bio
Date: Mon, 10 May 2021 21:49:16 +0200 [thread overview]
Message-ID: <6ffb719e-bb56-8f61-9cd3-a0852c4acb7d@intel.com> (raw)
In-Reply-To: <14a350ee-1ec9-6a15-dd76-fb01d8dd2235@gmail.com>
On 5/10/21 9:46 AM, Guoqing Jiang wrote:
> On 5/10/21 2:00 PM, Christoph Hellwig wrote:
>> On Sat, May 08, 2021 at 11:48:15AM +0800, Guoqing Jiang wrote:
>>> It looks like stack overflow happened for split bio, to fix this,
>>> let's keep split bio untouched in md_submit_bio.
>>>
>>> As a side effect, we need to export bio_chain_endio.
>> Err, no. The right answer is to not change ->bi_end_io of bios that
>> you do not own instead of using a horrible hack to skip accounting for
>> bios that have no more or less reason to be accounted than others bios.
>
> Thanks for the reply. I suppose that md needs to revert current
> implementation of accounting io stats, then re-implement it.
>
> Song and Artur, what are your opinion?
In the initial version of the io accounting patch the bio was cloned instead
of just overriding bi_end_io and bi_private. Would this be the right approach?
https://lore.kernel.org/linux-raid/20200601161256.27718-1-artur.paszkiewicz@intel.com/
next prev parent reply other threads:[~2021-05-10 19:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:48 [PATCH] md: don't account io stat for split bio Guoqing Jiang
2021-05-10 6:00 ` Christoph Hellwig
2021-05-10 7:46 ` Guoqing Jiang
2021-05-10 19:49 ` Artur Paszkiewicz [this message]
2021-05-11 2:13 ` Guoqing Jiang
2021-05-11 4:38 ` Christoph Hellwig
2021-05-11 6:59 ` Song Liu
2021-05-11 7:11 ` Christoph Hellwig
2021-05-11 6:58 ` Song Liu
2021-05-11 7:10 ` Christoph Hellwig
2021-05-13 7:24 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ffb719e-bb56-8f61-9cd3-a0852c4acb7d@intel.com \
--to=artur.paszkiewicz@intel.com \
--cc=hch@infradead.org \
--cc=jgq516@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=pawel.wiejacha@rtbhouse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).