From: Christoph Hellwig <hch@infradead.org>
To: Guoqing Jiang <jgq516@gmail.com>
Cc: Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
Christoph Hellwig <hch@infradead.org>,
song@kernel.org, linux-raid@vger.kernel.org,
linux-block@vger.kernel.org, pawel.wiejacha@rtbhouse.com
Subject: Re: [PATCH] md: don't account io stat for split bio
Date: Tue, 11 May 2021 05:38:17 +0100 [thread overview]
Message-ID: <YJoKOT8U7+9fyraj@infradead.org> (raw)
In-Reply-To: <c1bc42ff-eae7-d0ba-505d-9c6a19d60e93@gmail.com>
On Tue, May 11, 2021 at 10:13:41AM +0800, Guoqing Jiang wrote:
> > > Song and Artur, what are your opinion?
> > In the initial version of the io accounting patch the bio was cloned instead
> > of just overriding bi_end_io and bi_private. Would this be the right approach?
> >
> > https://lore.kernel.org/linux-raid/20200601161256.27718-1-artur.paszkiewicz@intel.com/
>
> Maybe we can have different approach for different personality layers.
>
> 1. raid1 and raid10 can do the accounting in their own layer since they
> already
> ?????? clone bio here.
> 2. make the initial version handles other personality such as raid0 and
> raid5
> ?????? in the md layer.
>
> Also a sysfs node which can enable/disable the accounting could be helpful.
Yes. Also if the original bi_end_io is restore before completing the
bio you can still override it.
next prev parent reply other threads:[~2021-05-11 4:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 3:48 [PATCH] md: don't account io stat for split bio Guoqing Jiang
2021-05-10 6:00 ` Christoph Hellwig
2021-05-10 7:46 ` Guoqing Jiang
2021-05-10 19:49 ` Artur Paszkiewicz
2021-05-11 2:13 ` Guoqing Jiang
2021-05-11 4:38 ` Christoph Hellwig [this message]
2021-05-11 6:59 ` Song Liu
2021-05-11 7:11 ` Christoph Hellwig
2021-05-11 6:58 ` Song Liu
2021-05-11 7:10 ` Christoph Hellwig
2021-05-13 7:24 ` Guoqing Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YJoKOT8U7+9fyraj@infradead.org \
--to=hch@infradead.org \
--cc=artur.paszkiewicz@intel.com \
--cc=jgq516@gmail.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=pawel.wiejacha@rtbhouse.com \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).