Re: [GIT PULL] Block driver changes for 5.20-rc1

From: Jens Axboe <axboe@kernel.dk>
To: Keith Busch <kbusch@kernel.org>,
	Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
	Hannes Reinecke <hare@suse.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Block driver changes for 5.20-rc1
Date: Tue, 2 Aug 2022 15:35:23 -0600	[thread overview]
Message-ID: <74bb310b-b602-14eb-85f7-4b08327b0092@kernel.dk> (raw)
In-Reply-To: <YumYKVWYnoALoSBR@kbusch-mbp.dhcp.thefacebook.com>

On 8/2/22 3:33 PM, Keith Busch wrote:
> On Tue, Aug 02, 2022 at 02:18:57PM -0700, Linus Torvalds wrote:
>> And no, I don't want some "fix up broken code after the fact" commit
>> on top. I want that code excised, and I don't want to see another pull
>> request before it's (a) gone and (b) somebody has looked at where the
>> testing of this COMPLETELY failed.
> 
> This issue was fixed more than 2 weeks ago, but wasn't included in this pull
> request. It's in the current block drivers-post tree, though:
> 
>   https://git.kernel.dk/cgit/linux-block/commit/?h=for-5.20/drivers-post&id=4dfbd5418763018f33acded0871fbbc22c8e4695
> 
> Do you want us to rebase the nvme pull request with the above squashed
> into the original commit instead?

I can just rebase drivers and drivers-post into one now that the core
bits are in. It was a bit of a pain since later driver changes ended up
needing more core changes (and has made me re-think the split approach,
I want to make this one block branch going forward since this isn't the
first time).

But if I just rebase drivers + drivers-post into one branch, then I can
squash the commit.

As to testing, I'm going to punt that question to Hannes and Christoph,
as I have no way of testing that particular NVMe feature.

-- 
Jens Axboe