linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Jens Axboe <axboe@kernel.dk>
Cc: Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>,
	Sagi Grimberg <sagi@grimberg.me>, Hannes Reinecke <hare@suse.de>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [GIT PULL] Block driver changes for 5.20-rc1
Date: Tue, 2 Aug 2022 14:50:52 -0700	[thread overview]
Message-ID: <CAHk-=wgAeL8+BYsy4mnut+y7sBF_+LXmW5bjUfegBpg8SisBJQ@mail.gmail.com> (raw)
In-Reply-To: <74bb310b-b602-14eb-85f7-4b08327b0092@kernel.dk>

On Tue, Aug 2, 2022 at 2:35 PM Jens Axboe <axboe@kernel.dk> wrote:
>
>
> As to testing, I'm going to punt that question to Hannes and Christoph,
> as I have no way of testing that particular NVMe feature.

I can't test the *feature* either.

But dammit, I test two very different build configurations, and both
of them failed miserably on this file.

Don't you get it? That file DOES NOT EVEN COMPILE.

I refuse to have anything to do with a pull request that doesn't even
pass some very fundamental build requirements for me. That implies a
level of lack of testing that just makes me go "No way am I touching
that tree".

                 Linus

  reply	other threads:[~2022-08-02 21:51 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-31 15:03 [GIT PULL] Block driver changes for 5.20-rc1 Jens Axboe
2022-08-02 21:18 ` Linus Torvalds
2022-08-02 21:33   ` Keith Busch
2022-08-02 21:35     ` Jens Axboe
2022-08-02 21:50       ` Linus Torvalds [this message]
2022-08-02 22:24         ` Jens Axboe
2022-08-02 22:26           ` Jens Axboe
2022-08-02 22:27           ` Linus Torvalds
2022-08-02 22:33             ` Jens Axboe
2022-08-02 22:48               ` Linus Torvalds
2022-08-02 22:59                 ` Jens Axboe
2022-08-02 23:03                   ` Linus Torvalds
2022-08-02 23:08                     ` Jens Axboe
2022-08-03 15:16                       ` Jens Axboe
2022-08-03 16:26                         ` Linus Torvalds
2022-08-03 16:51                           ` Nick Desaulniers
2022-08-03 16:53                             ` Jens Axboe
2022-08-03 17:00                               ` Linus Torvalds
2022-08-03 17:38                               ` Nick Desaulniers
2022-08-03 17:45                                 ` Jens Axboe
2022-08-03 18:06                                   ` Nick Desaulniers
2022-08-04 16:17                                     ` Jens Axboe
2022-08-03 16:56                             ` Linus Torvalds
2022-08-03 17:30   ` Christoph Hellwig
2022-08-03 17:42     ` Linus Torvalds
2022-08-03 17:49       ` Christoph Hellwig
2022-08-03 17:54         ` Linus Torvalds
2022-08-06  7:44           ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgAeL8+BYsy4mnut+y7sBF_+LXmW5bjUfegBpg8SisBJQ@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=axboe@kernel.dk \
    --cc=hare@suse.de \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=sagi@grimberg.me \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).