From: Paolo Valente <paolo.valente@linaro.org>
To: Tejun Heo <tj@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jens Axboe <axboe@kernel.dk>, Li Zefan <lizefan@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Johannes Thumshirn <jthumshirn@suse.de>,
Ulf Hansson <ulf.hansson@linaro.org>,
Linus Walleij <linus.walleij@linaro.org>,
Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH block/for-5.2-fixes] bfq: use io.weight interface file instead of io.bfq.weight
Date: Fri, 14 Jun 2019 23:05:36 +0200 [thread overview]
Message-ID: <78B23D07-0EF6-4FBA-8B21-5C028699C450@linaro.org> (raw)
In-Reply-To: <20190614202222.GC657710@devbig004.ftw2.facebook.com>
> Il giorno 14 giu 2019, alle ore 22:22, Tejun Heo <tj@kernel.org> ha scritto:
>
> Hello,
>
> On Thu, Jun 13, 2019 at 08:10:38AM +0200, Paolo Valente wrote:
>> BFQ does not implement weight_device, but we are not talking about
>> weight_device here. More precisely, *nothing* implements weight_device
>> any longer in cgroups-v1, so the documentation is wrong altogether.
>
> I can't see how renaming an interface file which has different
> behaviors on the same input to the same name is something acceptable.
> Imagine how confusing that'd be to userspace. If you want to rename
> the control knob to io.weight, please implement full semantics for
> both cgroup1 and cgroup2.
>
I want to, and I've tried to make it easier for you to point me to
what is missing exactly. Once again, the only missing piece I see are
per-device weights.
> I just posted a separate io.weight implementation for cgroup2 but it's
> easy to provide a way to override the interface files when bfq gets
> selected, so let me know when you have a working implementation of the
> interface.
>
Ok, thanks. I'll ping you when also per-device weights are available
in BFQ's interface.
Thanks,
Paolo
> Thanks.
>
> --
> tejun
next prev parent reply other threads:[~2019-06-14 21:05 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-08 8:20 [GIT PULL] Block fixes for 5.2-rc4 Jens Axboe
2019-06-08 19:28 ` Linus Torvalds
2019-06-09 5:59 ` Jens Axboe
2019-06-09 16:06 ` Linus Torvalds
2019-06-10 10:15 ` Jens Axboe
2019-06-10 14:49 ` Paolo Valente
2019-06-10 15:48 ` Tejun Heo
2019-06-11 19:49 ` [PATCH block/for-5.2-fixes] bfq: use io.weight interface file instead of io.bfq.weight Tejun Heo
2019-06-11 21:17 ` Tejun Heo
2019-06-12 7:32 ` Paolo Valente
2019-06-12 13:39 ` Tejun Heo
2019-06-13 6:10 ` Paolo Valente
2019-06-14 20:22 ` Tejun Heo
2019-06-14 21:05 ` Paolo Valente [this message]
2019-08-20 6:58 ` Paolo Valente
2019-06-08 19:30 ` [GIT PULL] Block fixes for 5.2-rc4 pr-tracker-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=78B23D07-0EF6-4FBA-8B21-5C028699C450@linaro.org \
--to=paolo.valente@linaro.org \
--cc=axboe@kernel.dk \
--cc=fam@euphon.net \
--cc=hannes@cmpxchg.org \
--cc=jthumshirn@suse.de \
--cc=linus.walleij@linaro.org \
--cc=linux-block@vger.kernel.org \
--cc=lizefan@huawei.com \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).