linux-block.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sagi Grimberg <sagi@grimberg.me>
To: linux-block@vger.kernel.org, Omar Sandoval <osandov@osandov.com>
Cc: linux-nvme@lists.infradead.org,
	Logan Gunthorpe <logang@deltatee.com>,
	Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
	Keith Busch <kbusch@kernel.org>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v7 0/7] blktests: Add support to run nvme tests with tcp/rdma transports
Date: Fri, 11 Sep 2020 15:06:45 -0700	[thread overview]
Message-ID: <7af726d8-b469-d36c-7be7-252b3bbace54@grimberg.me> (raw)
In-Reply-To: <20200903235337.527880-1-sagi@grimberg.me>


> We have a collection of nvme tests, but all run with nvme-loop. This
> is the easiest to run on a standalone machine. However its very much possible
> to run nvme-tcp and nvme-rdma using a loopback network. Add capability to run
> tests with a new environment variable to set the transport type $nvme_trtype.
> 
> $ nvme_trtype=[loop|tcp|rdma] ./check nvme
> 
> This buys us some nice coverage on some more transport types. We also add
> some transport type specific helpers to mark tests that are relevant only
> for a single transport.
> 
> Changes from v6:
> - fix _nvme_discover wrong use of subsysnqn that is never passed
> - move shellcheck fixes to the correct patches (not fix in subsequent patches)
> Changes from v5:
> - fix shellcheck errors
> Changes from v4:
> - removed extra paranthesis
> - load either rdma_rxe or siw for rdma transport tests
> Changes from v3:
> - remove unload_module from tests/srp/rc
> - fixed test run cmd
> Changes from v2:
> - changed patch 6 to move unload_module to common/rc
> - changed helper to be named _require_nvme_trtype_is_fabrics
> Changes from v1:
> - added patch to remove use of module_unload
> - move trtype agnostic logig helpers in patch #3

Omar, anything left on your end to take this?

  parent reply	other threads:[~2020-09-11 22:06 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-03 23:53 [PATCH v7 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-09-03 23:53 ` [PATCH v7 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-09-04  0:18   ` Chaitanya Kulkarni
2020-09-14 21:51   ` Omar Sandoval
2020-09-14 22:04     ` Logan Gunthorpe
2020-09-14 22:09       ` Omar Sandoval
2020-09-14 22:23         ` Logan Gunthorpe
2020-09-14 22:25           ` Omar Sandoval
2020-09-03 23:53 ` [PATCH v7 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-09-04  0:19   ` Chaitanya Kulkarni
2020-09-03 23:53 ` [PATCH v7 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-09-04  0:20   ` Chaitanya Kulkarni
2020-09-03 23:53 ` [PATCH v7 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-09-04  0:21   ` Chaitanya Kulkarni
2020-09-14 21:53   ` Omar Sandoval
2020-09-03 23:53 ` [PATCH v7 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-09-04  0:21   ` Chaitanya Kulkarni
2020-09-03 23:53 ` [PATCH v7 6/7] common: move module_unload to common Sagi Grimberg
2020-09-04  0:22   ` Chaitanya Kulkarni
2020-09-03 23:53 ` [PATCH v7 7/7] nvme: support rdma transport type Sagi Grimberg
2020-09-04  0:23   ` Chaitanya Kulkarni
2020-09-04 17:00   ` Yi Zhang
2020-09-04 15:52 ` [PATCH v7 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Logan Gunthorpe
2020-09-11 22:06 ` Sagi Grimberg [this message]
2020-09-25 17:32 ` Omar Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7af726d8-b469-d36c-7be7-252b3bbace54@grimberg.me \
    --to=sagi@grimberg.me \
    --cc=Chaitanya.Kulkarni@wdc.com \
    --cc=hch@lst.de \
    --cc=kbusch@kernel.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=logang@deltatee.com \
    --cc=osandov@osandov.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).