* block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges")
@ 2021-11-04 14:04 Holger Hoffstätte
2021-11-04 14:41 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Holger Hoffstätte @ 2021-11-04 14:04 UTC (permalink / raw)
To: linux-block, Jens Axboe
Hi Jens,
a simple no-code request:
Commit d29bd41428cf ("block, bfq: reset last_bfqq_created on group change")
fixed a UAF in bfq, which was previously worked-around by ebc69e897e17
("Revert "block, bfq: honor already-setup queue merges"").
However since then the original commit 2d52c58b9c9b was never restored.
Reinstating 2d52c58b9c9b has so far not resulted in any problems for me,
and I think it would be nice to bring it back in early just to get
feedback as early as possible in this cycle.
Thanks,
Holger
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges")
2021-11-04 14:04 block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges") Holger Hoffstätte
@ 2021-11-04 14:41 ` Jens Axboe
2021-11-05 9:43 ` Paolo Valente
0 siblings, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2021-11-04 14:41 UTC (permalink / raw)
To: Holger Hoffstätte, linux-block, Paolo Valente
On 11/4/21 8:04 AM, Holger Hoffstätte wrote:
>
> Hi Jens,
>
> a simple no-code request:
>
> Commit d29bd41428cf ("block, bfq: reset last_bfqq_created on group change")
> fixed a UAF in bfq, which was previously worked-around by ebc69e897e17
> ("Revert "block, bfq: honor already-setup queue merges"").
>
> However since then the original commit 2d52c58b9c9b was never restored.
>
> Reinstating 2d52c58b9c9b has so far not resulted in any problems for me,
> and I think it would be nice to bring it back in early just to get
> feedback as early as possible in this cycle.
Adding Paolo.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges")
2021-11-04 14:41 ` Jens Axboe
@ 2021-11-05 9:43 ` Paolo Valente
2021-11-05 14:33 ` Jens Axboe
0 siblings, 1 reply; 4+ messages in thread
From: Paolo Valente @ 2021-11-05 9:43 UTC (permalink / raw)
To: Jens Axboe; +Cc: Holger Hoffstätte, linux-block
> Il giorno 4 nov 2021, alle ore 15:41, Jens Axboe <axboe@kernel.dk> ha scritto:
>
> On 11/4/21 8:04 AM, Holger Hoffstätte wrote:
>>
>> Hi Jens,
>>
>> a simple no-code request:
>>
>> Commit d29bd41428cf ("block, bfq: reset last_bfqq_created on group change")
>> fixed a UAF in bfq, which was previously worked-around by ebc69e897e17
>> ("Revert "block, bfq: honor already-setup queue merges"").
>>
>> However since then the original commit 2d52c58b9c9b was never restored.
>>
>> Reinstating 2d52c58b9c9b has so far not resulted in any problems for me,
>> and I think it would be nice to bring it back in early just to get
>> feedback as early as possible in this cycle.
>
> Adding Paolo.
>
Yep, now that we have the fix, we should restore that commit.
Thanks Holger,
Paolo
> --
> Jens Axboe
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges")
2021-11-05 9:43 ` Paolo Valente
@ 2021-11-05 14:33 ` Jens Axboe
0 siblings, 0 replies; 4+ messages in thread
From: Jens Axboe @ 2021-11-05 14:33 UTC (permalink / raw)
To: Paolo Valente; +Cc: Holger Hoffstätte, linux-block
On 11/5/21 3:43 AM, Paolo Valente wrote:
>
>
>> Il giorno 4 nov 2021, alle ore 15:41, Jens Axboe <axboe@kernel.dk> ha scritto:
>>
>> On 11/4/21 8:04 AM, Holger Hoffstätte wrote:
>>>
>>> Hi Jens,
>>>
>>> a simple no-code request:
>>>
>>> Commit d29bd41428cf ("block, bfq: reset last_bfqq_created on group change")
>>> fixed a UAF in bfq, which was previously worked-around by ebc69e897e17
>>> ("Revert "block, bfq: honor already-setup queue merges"").
>>>
>>> However since then the original commit 2d52c58b9c9b was never restored.
>>>
>>> Reinstating 2d52c58b9c9b has so far not resulted in any problems for me,
>>> and I think it would be nice to bring it back in early just to get
>>> feedback as early as possible in this cycle.
>>
>> Adding Paolo.
>>
>
> Yep, now that we have the fix, we should restore that commit.
Please send a patch that does that then, with the rationale included
in the commit message on why it's now safe to do so.
--
Jens Axboe
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-05 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-11-04 14:04 block: please restore 2d52c58b9c9b ("block, bfq: honor already-setup queue merges") Holger Hoffstätte
2021-11-04 14:41 ` Jens Axboe
2021-11-05 9:43 ` Paolo Valente
2021-11-05 14:33 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).