* Re: block: add back the bd_holder_dir reference in bd_link_disk_holder [not found] <20210820094929.444848-1-hch@lst.de> @ 2021-08-20 17:20 ` Mike Snitzer 2021-08-21 3:14 ` Jens Axboe 0 siblings, 1 reply; 2+ messages in thread From: Mike Snitzer @ 2021-08-20 17:20 UTC (permalink / raw) To: Christoph Hellwig; +Cc: axboe, linux-block, tusharsu On Fri, Aug 20 2021 at 5:49P -0400, Christoph Hellwig <hch@lst.de> wrote: > This essentially reverts "block: remove the extra kobject reference in > bd_link_disk_holder". That commit dropped the extra reference because > the condition in the comment can't be true. But it turns out that > comment did not actually describe the problematic situation, so add > back the extra reference and document it properly. > > Fixes: fbd9a39542ec ("block: remove the extra kobject reference in bd_link_disk_holder") > Reported-by: Tushar Sugandhi <tusharsu@linux.microsoft.com> > Signed-off-by: Christoph Hellwig <hch@lst.de> Looks good, thanks. (btw, your linux-block cc had a typo, Jens are you able to pick this fix up regardless?) Reviewed-by: Mike Snitzer <snitzer@redhat.com> ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: block: add back the bd_holder_dir reference in bd_link_disk_holder 2021-08-20 17:20 ` block: add back the bd_holder_dir reference in bd_link_disk_holder Mike Snitzer @ 2021-08-21 3:14 ` Jens Axboe 0 siblings, 0 replies; 2+ messages in thread From: Jens Axboe @ 2021-08-21 3:14 UTC (permalink / raw) To: Mike Snitzer, Christoph Hellwig; +Cc: linux-block, tusharsu On 8/20/21 11:20 AM, Mike Snitzer wrote: > On Fri, Aug 20 2021 at 5:49P -0400, > Christoph Hellwig <hch@lst.de> wrote: > >> This essentially reverts "block: remove the extra kobject reference in >> bd_link_disk_holder". That commit dropped the extra reference because >> the condition in the comment can't be true. But it turns out that >> comment did not actually describe the problematic situation, so add >> back the extra reference and document it properly. >> >> Fixes: fbd9a39542ec ("block: remove the extra kobject reference in bd_link_disk_holder") >> Reported-by: Tushar Sugandhi <tusharsu@linux.microsoft.com> >> Signed-off-by: Christoph Hellwig <hch@lst.de> > > Looks good, thanks. > (btw, your linux-block cc had a typo, Jens are you able to pick this fix up regardless?) Yep, just did it manually. -- Jens Axboe ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-08-21 3:15 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20210820094929.444848-1-hch@lst.de>
2021-08-20 17:20 ` block: add back the bd_holder_dir reference in bd_link_disk_holder Mike Snitzer
2021-08-21 3:14 ` Jens Axboe
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).