From: Jens Axboe <axboe@kernel.dk>
To: Guenter Roeck <linux@roeck-us.net>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Cc: Ming Lei <ming.lei@redhat.com>, Omar Sandoval <osandov@osandov.com>
Subject: Re: [PATCH v2] sbitmap: silence bogus lockdep IRQ warning
Date: Sun, 9 Dec 2018 13:39:45 -0700 [thread overview]
Message-ID: <9fe4e245-6d95-22d7-8338-d98be22e82e7@kernel.dk> (raw)
In-Reply-To: <5d116e30-7a8d-aff5-68ca-9c3705d6f82e@roeck-us.net>
On 12/9/18 1:35 PM, Guenter Roeck wrote:
> I can't say anything about the correctness of this patch, but I no longer
> see any warnings.
>
> Tested-by: Guenter Roeck <linux@roeck-us.net>
Thanks for testing!
In terms of correctness, it does the right thing, just always makes it
an IRQ lock for lockdep. See analysis above. This is better than
disabling lockdep, since we'll still trigger other violations (like
ordering).
--
Jens Axboe
prev parent reply other threads:[~2018-12-09 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-09 18:24 [PATCH v2] sbitmap: silence bogus lockdep IRQ warning Jens Axboe
2018-12-09 18:47 ` Guenter Roeck
2018-12-09 20:34 ` Jens Axboe
2018-12-09 20:35 ` Guenter Roeck
2018-12-09 20:39 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9fe4e245-6d95-22d7-8338-d98be22e82e7@kernel.dk \
--to=axboe@kernel.dk \
--cc=linux-block@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=ming.lei@redhat.com \
--cc=osandov@osandov.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).