From: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>
To: Sagi Grimberg <sagi@grimberg.me>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
Omar Sandoval <osandov@osandov.com>
Cc: Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2 1/7] nvme: consolidate nvme requirements based on transport type
Date: Fri, 7 Aug 2020 02:41:51 +0000 [thread overview]
Message-ID: <BYAPR04MB496546CB79B5F7D4F4B0A54186490@BYAPR04MB4965.namprd04.prod.outlook.com> (raw)
In-Reply-To: 20200806191518.593880-2-sagi@grimberg.me
On 8/6/20 12:15, Sagi Grimberg wrote:
>
> diff --git a/tests/nvme/rc b/tests/nvme/rc
> index 6ffa971b4308..320aa4b2b475 100644
> --- a/tests/nvme/rc
> +++ b/tests/nvme/rc
> @@ -6,6 +6,25 @@
>
> . common/rc
>
> +nvme_trtype=${nvme_trtype:-"loop"}
> +
> +_nvme_requires() {
> + _have_program nvme
> + case ${nvme_trtype} in
> + loop)
> + _have_modules nvmet nvme-core nvme-loop
> + _have_configfs
We should just move nvmet nvme-core configfs _have_nvme_fabrics_common
which are common for all the transports to avoid the duplication.
> + ;;
> + pci)
> + _have_modules nvme nvme-core
> + ;;
> + *)
> + SKIP_REASON="unsupported nvme_trtype=${nvme_trtype}"
> + return 1
> + esac
> + return 0
> +}
> +
> group_requires() {
> _have_root
> }
> -- 2.25.1
Apart from that it looks good to me, I've not tested this yet though.
next prev parent reply other threads:[~2020-08-07 2:41 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:15 [PATCH v2 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-08-07 2:41 ` Chaitanya Kulkarni [this message]
2020-08-07 17:14 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-08-07 2:53 ` Chaitanya Kulkarni
2020-08-07 17:15 ` Sagi Grimberg
2020-08-08 1:47 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-08-07 3:09 ` Chaitanya Kulkarni
2020-08-07 17:19 ` Sagi Grimberg
2020-08-10 17:35 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-08-07 3:15 ` Chaitanya Kulkarni
2020-08-07 17:21 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-08-07 3:16 ` Chaitanya Kulkarni
2020-08-07 23:46 ` Sagi Grimberg
2020-08-08 1:49 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload Sagi Grimberg
2020-08-07 3:18 ` Chaitanya Kulkarni
2020-08-07 14:03 ` Bart Van Assche
2020-08-07 17:23 ` Sagi Grimberg
2020-08-07 17:34 ` Bart Van Assche
2020-08-07 17:50 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 7/7] nvme: support rdma transport type Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BYAPR04MB496546CB79B5F7D4F4B0A54186490@BYAPR04MB4965.namprd04.prod.outlook.com \
--to=chaitanya.kulkarni@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).