From: Bart Van Assche <bvanassche@acm.org>
To: Sagi Grimberg <sagi@grimberg.me>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
Omar Sandoval <osandov@osandov.com>
Cc: Chaitanya Kulkarni <Chaitanya.Kulkarni@wdc.com>,
Johannes Thumshirn <Johannes.Thumshirn@wdc.com>,
Christoph Hellwig <hch@lst.de>, Keith Busch <kbusch@kernel.org>
Subject: Re: [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload
Date: Fri, 7 Aug 2020 10:34:24 -0700 [thread overview]
Message-ID: <b3ab660e-fd36-36da-fdff-f7582baf47fc@acm.org> (raw)
In-Reply-To: <155cb916-062f-e23f-9790-35dee850687b@grimberg.me>
On 2020-08-07 10:23, Sagi Grimberg wrote:
>
>>> There is no need to retry module unload for rdma_rxe
>>> and siw. This also creates a dependency on
>>> tests/nvmeof/rc which prevents it from using in
>>> other test subsystems.
>>
>> If it wouldn't be necessary to retry module unload I wouldn't have
>> introduced a loop.
>
> I thought it was to work-around a driver issue as these drivers
> traditionally had plenty of stability issues.
>
> To be honest this retry loop to me indicated that either the
> driver has a bug or the test. But maybe there is a need I
> am not seeing.
That loop was introduced a long time ago. I haven't tried to root-cause
it but my guess is that the loop is necessary because the module refcount
only drops to zero a short time after the first attempt to unload these
kernel modules.
Bart.
next prev parent reply other threads:[~2020-08-07 17:34 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-06 19:15 [PATCH v2 0/7] blktests: Add support to run nvme tests with tcp/rdma transports Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 1/7] nvme: consolidate nvme requirements based on transport type Sagi Grimberg
2020-08-07 2:41 ` Chaitanya Kulkarni
2020-08-07 17:14 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 2/7] nvme: consolidate some nvme-cli utility functions Sagi Grimberg
2020-08-07 2:53 ` Chaitanya Kulkarni
2020-08-07 17:15 ` Sagi Grimberg
2020-08-08 1:47 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 3/7] nvme: make tests transport type agnostic Sagi Grimberg
2020-08-07 3:09 ` Chaitanya Kulkarni
2020-08-07 17:19 ` Sagi Grimberg
2020-08-10 17:35 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 4/7] tests/nvme: restrict tests to specific transports Sagi Grimberg
2020-08-07 3:15 ` Chaitanya Kulkarni
2020-08-07 17:21 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 5/7] nvme: support nvme-tcp when runinng tests Sagi Grimberg
2020-08-07 3:16 ` Chaitanya Kulkarni
2020-08-07 23:46 ` Sagi Grimberg
2020-08-08 1:49 ` Chaitanya Kulkarni
2020-08-06 19:15 ` [PATCH v2 6/7] common/multipath-over-rdma: don't retry module unload Sagi Grimberg
2020-08-07 3:18 ` Chaitanya Kulkarni
2020-08-07 14:03 ` Bart Van Assche
2020-08-07 17:23 ` Sagi Grimberg
2020-08-07 17:34 ` Bart Van Assche [this message]
2020-08-07 17:50 ` Sagi Grimberg
2020-08-06 19:15 ` [PATCH v2 7/7] nvme: support rdma transport type Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b3ab660e-fd36-36da-fdff-f7582baf47fc@acm.org \
--to=bvanassche@acm.org \
--cc=Chaitanya.Kulkarni@wdc.com \
--cc=Johannes.Thumshirn@wdc.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=osandov@osandov.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).