[PATCH blktests v3 0/2] nmve/018 fixes

[PATCH blktests v3 0/2] nmve/018 fixes

[Daniel Wagner]

changes from v2:
  - fixed another typo (argh!)
  - added reviewed-by tag from Keith

changes from v1:
  - added reviewed-by tag from Logan
  - patch #2 fixed typo in commit message
  - patch #2 reworded error message as suggested by Robert

changes from v0:
  - added "nmve/018: Reword misleading error message"

Daniel Wagner (2):
  nvme/018: Ignore message generated by nvme read
  nvme/018: Reword misleading error message

 tests/nvme/018 | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

-- 
2.16.4

[PATCH blktests v3 1/2] nvme/018: Ignore message generated by nvme read

[Daniel Wagner]

nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
stderr. This lets the test fail as well.

Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
---
 tests/nvme/018 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/nvme/018 b/tests/nvme/018
index 0a5b4c2ab019..d0f15db23538 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -43,7 +43,7 @@ test() {
 	sectors="$(blockdev --getsz "/dev/${nvmedev}n1")"
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
-	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" 2>"$FULL" \
+	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
 		&& echo "ERROR: Successfully read out of device lba range"
 
 	nvme disconnect -n "${subsys_name}"
-- 
2.16.4

[PATCH blktests v3 2/2] nvme/018: Reword misleading error message

[Daniel Wagner]

'nvme read' is expected to fail, though the error message "ERROR:
Successfully..." is misleading. Reword the error text to clarify the
real intent of the test and what failed.

Reported-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Daniel Wagner <dwagner@suse.de>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Reviewed-by: Keith Busch <kbusch@kernel.org>
---
 tests/nvme/018 | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/nvme/018 b/tests/nvme/018
index d0f15db23538..67d89a6f0b24 100755
--- a/tests/nvme/018
+++ b/tests/nvme/018
@@ -3,7 +3,7 @@
 # Copyright (C) 2018 Sagi Grimberg
 #
 # Test NVMe out of range access on a file backend. Regression test for commit
-# 9c891c139894 ("nvmet: check fileio lba range access boundaries").
+# 9c891c139894 ("nvmet: check fileio LBA range access boundaries").
 
 . tests/nvme/rc
 
@@ -44,7 +44,7 @@ test() {
 	bs="$(blockdev --getbsz "/dev/${nvmedev}n1")"
 
 	nvme read "/dev/${nvmedev}n1" -s "$sectors" -c 0 -z "$bs" &>"$FULL" \
-		&& echo "ERROR: Successfully read out of device lba range"
+		&& echo "ERROR: nvme read for out of range LBA was not rejected"
 
 	nvme disconnect -n "${subsys_name}"
 
-- 
2.16.4

Re: [PATCH blktests v3 2/2] nvme/018: Reword misleading error message

[Chaitanya Kulkarni]

On 02/03/2020 08:41 AM, Daniel Wagner wrote:
> 'nvme read' is expected to fail, though the error message "ERROR:
> Successfully..." is misleading. Reword the error text to clarify the
> real intent of the test and what failed.
>
> Reported-by: Logan Gunthorpe<logang@deltatee.com>
> Signed-off-by: Daniel Wagner<dwagner@suse.de>
> Reviewed-by: Logan Gunthorpe<logang@deltatee.com>
> Reviewed-by: Keith Busch<kbusch@kernel.org>
> ---
Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

Re: [PATCH blktests v3 1/2] nvme/018: Ignore message generated by nvme read

[Chaitanya Kulkarni]

On 02/03/2020 08:41 AM, Daniel Wagner wrote:
> nvme-cli writes 'CAP_EXCEEDED' message also on stdout not just
> stderr. This lets the test fail as well.
>
> Fixes: 1aee5f430b30 ("nvme/018: Ignore error message generated by nvme read")
> Signed-off-by: Daniel Wagner<dwagner@suse.de>
> Reviewed-by: Logan Gunthorpe<logang@deltatee.com>
> Reviewed-by: Keith Busch<kbusch@kernel.org>

Reviewed-by: Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>

Re: [PATCH blktests v3 0/2] nmve/018 fixes

[Omar Sandoval]

On Mon, Feb 03, 2020 at 05:40:47PM +0100, Daniel Wagner wrote:
> changes from v2:
>   - fixed another typo (argh!)
>   - added reviewed-by tag from Keith
> 
> changes from v1:
>   - added reviewed-by tag from Logan
>   - patch #2 fixed typo in commit message
>   - patch #2 reworded error message as suggested by Robert
> 
> changes from v0:
>   - added "nmve/018: Reword misleading error message"
> 
> Daniel Wagner (2):
>   nvme/018: Ignore message generated by nvme read
>   nvme/018: Reword misleading error message
> 
>  tests/nvme/018 | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

Thanks, applied and pushed.