Linux-Block Archive on lore.kernel.org
 help / Atom feed
* [PATCH] block: doc: add slice_idle_us to bfq documentation
@ 2019-01-08 21:56 John Pittman
  2019-01-09  6:08 ` Paolo Valente
  2019-01-09 14:39 ` Jens Axboe
  0 siblings, 2 replies; 4+ messages in thread
From: John Pittman @ 2019-01-08 21:56 UTC (permalink / raw)
  To: paolo.valente; +Cc: axboe, corbet, linux-block, linux-doc, John Pittman

Of the tunables available for the bfq I/O scheduler,
the only one missing from the documentation in
'Documentation/block/bfq-iosched.txt' is slice_idle_us.
Add this tunable to the documentation and a short
explanation of its purpose.

Signed-off-by: John Pittman <jpittman@redhat.com>
---
 Documentation/block/bfq-iosched.txt | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq-iosched.txt
index 8d8d8f06cab2..98a8dd5ee385 100644
--- a/Documentation/block/bfq-iosched.txt
+++ b/Documentation/block/bfq-iosched.txt
@@ -357,6 +357,13 @@ video playing/streaming, a very low drop rate may be more important
 than maximum throughput. In these cases, consider setting the
 strict_guarantees parameter.
 
+slice_idle_us
+-------------
+
+Controls the same tuning parameter as slice_idle, but in microseconds.
+Either tunable can be used to set idling behavior.  Afterwards, the
+other tunable will reflect the newly set value in sysfs.
+
 strict_guarantees
 -----------------
 
-- 
2.17.2


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: doc: add slice_idle_us to bfq documentation
  2019-01-08 21:56 [PATCH] block: doc: add slice_idle_us to bfq documentation John Pittman
@ 2019-01-09  6:08 ` Paolo Valente
  2019-01-09 14:39 ` Jens Axboe
  1 sibling, 0 replies; 4+ messages in thread
From: Paolo Valente @ 2019-01-09  6:08 UTC (permalink / raw)
  To: John Pittman
  Cc: Jens Axboe, Jonathan Corbet, linux-block, linux-doc, Mark Brown,
	Linus Walleij, Ulf Hansson



> Il giorno 8 gen 2019, alle ore 22:56, John Pittman <jpittman@redhat.com> ha scritto:
> 
> Of the tunables available for the bfq I/O scheduler,
> the only one missing from the documentation in
> 'Documentation/block/bfq-iosched.txt' is slice_idle_us.
> Add this tunable to the documentation and a short
> explanation of its purpose.
> 
> Signed-off-by: John Pittman <jpittman@redhat.com>

Acked-by: Paolo Valente <paolo.valente@linaro.org>

Thank you for adding this missing piece,
Paolo

> ---
> Documentation/block/bfq-iosched.txt | 7 +++++++
> 1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/block/bfq-iosched.txt b/Documentation/block/bfq-iosched.txt
> index 8d8d8f06cab2..98a8dd5ee385 100644
> --- a/Documentation/block/bfq-iosched.txt
> +++ b/Documentation/block/bfq-iosched.txt
> @@ -357,6 +357,13 @@ video playing/streaming, a very low drop rate may be more important
> than maximum throughput. In these cases, consider setting the
> strict_guarantees parameter.
> 
> +slice_idle_us
> +-------------
> +
> +Controls the same tuning parameter as slice_idle, but in microseconds.
> +Either tunable can be used to set idling behavior.  Afterwards, the
> +other tunable will reflect the newly set value in sysfs.
> +
> strict_guarantees
> -----------------
> 
> -- 
> 2.17.2
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: doc: add slice_idle_us to bfq documentation
  2019-01-08 21:56 [PATCH] block: doc: add slice_idle_us to bfq documentation John Pittman
  2019-01-09  6:08 ` Paolo Valente
@ 2019-01-09 14:39 ` Jens Axboe
  2019-01-09 15:16   ` John Pittman
  1 sibling, 1 reply; 4+ messages in thread
From: Jens Axboe @ 2019-01-09 14:39 UTC (permalink / raw)
  To: John Pittman, paolo.valente; +Cc: corbet, linux-block, linux-doc

On 1/8/19 2:56 PM, John Pittman wrote:
> Of the tunables available for the bfq I/O scheduler,
> the only one missing from the documentation in
> 'Documentation/block/bfq-iosched.txt' is slice_idle_us.
> Add this tunable to the documentation and a short
> explanation of its purpose.

Applied, but I fixed up your commit message. You should use 72
chars lengths.

-- 
Jens Axboe


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] block: doc: add slice_idle_us to bfq documentation
  2019-01-09 14:39 ` Jens Axboe
@ 2019-01-09 15:16   ` John Pittman
  0 siblings, 0 replies; 4+ messages in thread
From: John Pittman @ 2019-01-09 15:16 UTC (permalink / raw)
  To: Jens Axboe; +Cc: paolo.valente, Jonathan Corbet, linux-block, linux-doc

Thanks; noted.


On Wed, Jan 9, 2019 at 9:39 AM Jens Axboe <axboe@kernel.dk> wrote:
>
> On 1/8/19 2:56 PM, John Pittman wrote:
> > Of the tunables available for the bfq I/O scheduler,
> > the only one missing from the documentation in
> > 'Documentation/block/bfq-iosched.txt' is slice_idle_us.
> > Add this tunable to the documentation and a short
> > explanation of its purpose.
>
> Applied, but I fixed up your commit message. You should use 72
> chars lengths.
>
> --
> Jens Axboe
>

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, back to index

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 21:56 [PATCH] block: doc: add slice_idle_us to bfq documentation John Pittman
2019-01-09  6:08 ` Paolo Valente
2019-01-09 14:39 ` Jens Axboe
2019-01-09 15:16   ` John Pittman

Linux-Block Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-block/0 linux-block/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-block linux-block/ https://lore.kernel.org/linux-block \
		linux-block@vger.kernel.org linux-block@archiver.kernel.org
	public-inbox-index linux-block


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-block


AGPL code for this site: git clone https://public-inbox.org/ public-inbox